From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout01.t-online.de (mailout01.t-online.de [194.25.134.80]) by sourceware.org (Postfix) with ESMTPS id BBA6C3875450 for ; Wed, 26 Jun 2024 22:12:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBA6C3875450 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBA6C3875450 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.80 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719439981; cv=none; b=pOUdWu9eNblwMG+x8vvFEkAOsHc4psQ5dVJOq1IRIwnjyA3ETHmjBaKy2YR3Mln6rrGAysP6NAHIXBtFbwzS8d58MKs9dSZIiSd6zoyT3tYRYipe7ecWxACsS61L30DlmF6J4ngXz7OKGQdBfcD0wJVA3hzLDK3CpHK8MZLXDXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719439981; c=relaxed/simple; bh=dLpuK1vELZHwIUIcb7m60Mo4W9GnixuBxPvNGevLPU4=; h=Message-ID:Subject:From:To:Date:MIME-Version; b=KdqrNUIdREETnf39iyURpWv4uW1OmxxEyJJTRmMcE8+7nYNeQEXxV6JVBRJMxSxgpudmZvpgAjpD0KcaexQzI2/lZtGKMraHUggTPuWwc5BLL69vt9YSlw130/r+XdJzdfQkeKgxbAfO1MLfWenxMT/xoCYUQB+MMTkkG0QQki4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fwd76.aul.t-online.de (fwd76.aul.t-online.de [10.223.144.102]) by mailout01.t-online.de (Postfix) with SMTP id 36ADD2210B; Thu, 27 Jun 2024 00:12:51 +0200 (CEST) Received: from localhost.localdomain ([115.165.108.210]) by fwd76.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1sMasj-4dLYbw0; Thu, 27 Jun 2024 00:12:50 +0200 Message-ID: <2b196d4549b15f47c61b34c8e9da09035691b960.camel@t-online.de> Subject: Re: [committed] Remove compromised sh test From: Oleg Endo To: Jeff Law , "gcc-patches@gcc.gnu.org" Date: Thu, 27 Jun 2024 07:12:45 +0900 In-Reply-To: <9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com> References: <9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1719439971-477FDC95-CF7F8693/0/0 CLEAN NORMAL X-TOI-MSGID: e78a0625-6f3e-4224-b912-7df07f415a2c X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-06-26 at 07:22 -0600, Jeff Law wrote: > Surya's recent patch to IRA improves the code for sh/pr54602-1.c=20 > slightly. Specifically it's able to eliminate a save/restore in the=20 > prologue/epilogue and a bit of register shuffling. >=20 > As a result there literally aren't any insns that can be used to fill=20 > the delay slot of the return, so a nop gets emitted and the test fails. >=20 > Given there literally aren't any insns to move into the delay slot, the= =20 > best course of action is to just drop the test. >=20 > Pushed to the trunk. >=20 > Jeff I can't reproduce what you are saying. Which triplet and flags is your test setup using? For this test case, GCC 13 with -m4 -ml -O1 -fno-pic: _test01: mov.l r8,@-r15 sts.l pr,@-r15 mov.l .L3,r0 jsr @r0 mov r6,r8 add r8,r0 lds.l @r15+,pr rts =20 mov.l @r15+,r8 .L3: .long _test00 current GCC master branch with -m4 -ml -O1 -fno-pic: _test00: mov.l r8,@-r15 sts.l pr,@-r15 mov.l .L3,r0 jsr @r0 mov r6,r8 add r8,r0 lds.l @r15+,pr rts mov.l @r15+,r8 .L4: .align 2 .L3: .long _test01 Best regards, Oleg Endo