public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Julian Brown <julian@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] middle-end: Pretty-print address space of aggregates
Date: Tue, 2 Mar 2021 15:21:58 -0700	[thread overview]
Message-ID: <2b5bdd42-ad0a-b420-b2aa-d1b697754835@gmail.com> (raw)
In-Reply-To: <20210226120225.45340-1-julian@codesourcery.com>



On 2/26/21 5:02 AM, Julian Brown wrote:
> It's possible for an aggregate to be declared in a non-default address
> space, but the tree pretty-printer doesn't currently show that address
> space in dumps, which can be confusing.  This patch adds printing of
> "<address-space-N>" markers for aggregates in non-default address spaces.
>
> OK (now or for stage 1)?
>
> Thanks,
>
> Julian
>
> ChangeLog
>
> gcc/
> 	* tree-pretty-print.c (dump_generic_node): Emit non-generic
> 	address space info for aggregates.
Given this can't affect code generation, I think it's fine now.

OK for the trunk.

Jeff


      reply	other threads:[~2021-03-02 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 12:02 Julian Brown
2021-03-02 22:21 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b5bdd42-ad0a-b420-b2aa-d1b697754835@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=julian@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).