From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id B9D203858402 for ; Mon, 16 Oct 2023 20:22:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9D203858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9D203858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697487781; cv=none; b=hYRGxjoR9UN+dJqPnespu2XRx1tiofJ32W/y4YyVWQS+VqQw6Ype6QwwID2bpuEf3AChCSAgriZiKF9xj5UFnHaxXWvtJBHrgZLnSW/x1JpkUM4d3wvXR92BsHRU/6/GeIwYXxoiR4UP/ZrSbFFDXTi60kqt4gcsee6b7xt246w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697487781; c=relaxed/simple; bh=5loyw6Y9myfpoh/Gf9yTj97EpZ678tbif/tG/0r7Hww=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hPQ1pZScBCR/TJCJ3Sijycf/2LfsPBc3Pmfgn6QjhRIwMU0+VyheDhKNkh4I0H18V0msR0Dcbn4Qims3MOUM506Q4g9F9H2b/K2waxa05brs/SCAVFK/v/JLb0D4TD5VtjwkQd3oscliYqyL4rrEfWNJUZb9++Fqo+ft5oqfLqU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40684f53bfcso45911785e9.0 for ; Mon, 16 Oct 2023 13:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697487778; x=1698092578; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2VAz3PQqnu/SGcLMipm2+Jz7d7OF0XSGgvk3b6171nw=; b=XOSuBKA4q4wYMMx5IoCaP1+4R4iDJuWtRlq4zxVZA0k+QIz8Lpdrg2D+bvCUK4BQtp 3Vk9ytW4EMFb50by9w+AwK9s/4YLSX+Sj11uOgfuELZEsGgEHc8RC0qTALiKNMvbYutm 19DvS76pttpYJ40CX0CHvTO3Vww555y249U8pR1Du+M8q88vfpgsKjdk1BvZHywYs0at wYbMIgN5233HcKSpKh6O/yJAkZ7IpmJ85V4u8KycsSFhWaavHGX3OwjnTL0l0Fic3PNf 9rknlkotPSt4p8zPe7hGDKCiMztFFcJ9rMF+Nz9xLMBvGeMT4UGxLZOpS+eDsj0nw6XD /SqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697487778; x=1698092578; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2VAz3PQqnu/SGcLMipm2+Jz7d7OF0XSGgvk3b6171nw=; b=aF1RbkcRYSmDYKzc1Ot5kdvzggBYfyqU9S+qoN1xhohasu0ZyaOCZCItr60VqVQ+P1 3RHbph99NyS0vm0Y0AADPC17XaTNTn9uRKzl8mgXdJflgvMCkTcCX3+s/XGRW1gxYE33 jew8pqoj9WF57zXM9KtGjd3M5RL6n9Lv+PDIclFt6vvD553D6+fa9/AGmaG4ooHSNyNl rJlQr6WzVclsspfhv9kUjlEs5NbVVGGlG99skGyhW7htIbRLM/oV9EgvCHtic56Xy9BP UAuHD5AEz3K72pIObTUXUcWUXs4jJhY92HgqjvGvXLp/VWxFoVoonHoT3d+9mtO6JaXv 0NWw== X-Gm-Message-State: AOJu0YwHRTZnt28XVU2lrOZJzDlr8Bku0Kfq6Vfj6nMobha7WI1G+B4P quNUC3KiOHcdvMG9uHbyDpw= X-Google-Smtp-Source: AGHT+IGrbZdRYtWv1+wx42Vdx7CO1rOFb940VIMSMSp3eAPj5gdexPF7mKaym9dEwvELoAf+R4oM4g== X-Received: by 2002:a05:600c:1393:b0:402:cc9a:31a7 with SMTP id u19-20020a05600c139300b00402cc9a31a7mr168741wmf.19.1697487778179; Mon, 16 Oct 2023 13:22:58 -0700 (PDT) Received: from [192.168.1.24] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id s19-20020a05600c45d300b0040648217f4fsm8039321wmo.39.2023.10.16.13.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 13:22:57 -0700 (PDT) Message-ID: <2b838b57-04db-4ef4-9a41-e2de4e6451dc@gmail.com> Date: Mon, 16 Oct 2023 22:22:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH V3] RISC-V: Fix unexpected big LMUL choosing in dynamic LMUL model for non-adjacent load/store Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20231016141446.1942361-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20231016141446.1942361-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > + if (live_range && flow_bb_inside_loop_p (loop, e->src)) > + { Doesn't this match several cases more than before i.e set the range start to zero fairly often? I mean if it works fine with me and the code is easier to read. Please split off the search for the non-contiguous load/stores into a separate function still. With that change it's OK from my side. Regards Robin