From: "Martin Liška" <mliska@suse.cz>
To: Ian Lance Taylor <iant@golang.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Jonathan Wakely <jwakely.gcc@gmail.com>
Subject: Re: Patch RFA: Support non-ASCII file names in git-changelog
Date: Fri, 18 Dec 2020 11:28:48 +0100 [thread overview]
Message-ID: <2b8fc5da-0a7e-2feb-9d22-6fecc349d842@suse.cz> (raw)
In-Reply-To: <CAOyqgcVW5o+j+FvOo=9V293A5k46EaBVgJ=SrXB9Wyv2hgYYKw@mail.gmail.com>
On 12/17/20 5:26 AM, Ian Lance Taylor via Gcc-patches wrote:
> As discussed at
> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561995.html ,
> the ChangeLog checker does not correctly handle files with non-ASCII
> file names.
>
> This patch fixes the problem. I have little experience with Python,
> so I may have made some foolish mistakes here.
>
> OK to commit?
>
> Thanks.
>
> Ian
>
> * gcc-changelog/git_repository.py: Ignore quotation marks added by git
> for non-ASCII file names.
>
First, sorry for a slow response about the previous
thread (Change to gcc/testsuite/go.test/test rejected by ChangeLog checker).
Well, the suggested change will not help us because we will not be able
to find a file with a given path (\xxx\yyy...).
Proper solution is likely doing:
$ git config --global core.quotepath false
both on server side (and client side).
Having that, git properly displays non-ascii filenames:
commit 1814a090a816884892240752c927f7dbb50a10da
Author: Martin Liska <mliska@suse.cz>
Date: Fri Dec 18 11:00:52 2020 +0100
Add new file.
ChangeLog:
* špatně.txt: New file.
diff --git a/špatně.txt b/špatně.txt
new file mode 100644
index 00000000000..e69de29bb2d
Thoughts?
Martin
next prev parent reply other threads:[~2020-12-18 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 4:26 Ian Lance Taylor
2020-12-18 10:28 ` Martin Liška [this message]
2020-12-18 18:30 ` Ian Lance Taylor
2020-12-21 9:39 ` Martin Liška
2020-12-21 9:48 ` Jakub Jelinek
2020-12-21 9:57 ` Martin Liška
2020-12-24 12:16 ` Joel Brobecker
2021-01-04 11:01 ` Martin Liška
2021-01-04 11:47 ` Martin Liška
2021-01-06 7:25 ` Martin Liška
2021-01-06 13:37 ` Martin Liška
2021-01-07 19:03 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8fc5da-0a7e-2feb-9d22-6fecc349d842@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).