From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <10walls@gmail.com> Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 369263857C4E for ; Wed, 5 Oct 2022 09:34:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 369263857C4E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x430.google.com with SMTP id d10so15370006pfh.6 for ; Wed, 05 Oct 2022 02:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=w7aML5aWCevnx2RhjorsF3/uNoEUpuRueo0Wtc3oP/0=; b=Qpi28Xdx/u0kkgBV/j6fawxCAzBBejR+Z9XgwWtAWlhNoexfrHYZpSsEKtdjtAKysj DQQaJdtZ0phGr9l01TaktxQQnHyL1XtvOwZgrkn5fGfX9l4BMQLj3E48RJDd9vAJF5i7 tzZwgyUsazJ53PhelsA1WPH2yJQwaoBNJIcPqjpsHEIx/N+7D6GuHYWBjyFlDFbzvyhP XGo+OsPnXSEBqf1nsVGj+50XiL9X6dj4OE3YB9Elo6UPbmIQ3KS5hSBfltdIEYMjlai0 yi+6UH/wyhpB+YKv5VWDU2W7C06oiZPdahMEBsqk9M13/fv7G8Hao0oZgCLCHFaobaAz R/WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=w7aML5aWCevnx2RhjorsF3/uNoEUpuRueo0Wtc3oP/0=; b=MmA5xarvnhT1dldgV+kdl1VQC2xJckDItGWaJXwWzWXlVo6RYqTGvt49B11xeSYVDr nIaIcDEOYuBwvqDA6kTIUXFj25JY+xGvvSGLeJeyQnEfIh9jAP3LsfhLN2QBMFw7G1uT ifsD1ZgdViLCxZI8W9UK4/1gSQTZzfdrMt62P38/ptvzf4Ux1nlHmCuBsBHERhYV07P+ uTeYUdsPHNet7fFIXU7/DM28bH/WTe8UMq53vRufWkTe8lNJrNUG/uK09Lse6Ju4fwf/ cFTGmGzl7Yvn/pfcexfYeFLfrbinPYQMW6hkfUpJ3ZbTi3Zx7UPl8FKiaI5tw/5dIUVX z6rg== X-Gm-Message-State: ACrzQf32RgLV8pZKbx4qwfCPhWunTz+ET/+z6K7hABnGGjck8QZxPN5k ndpYzbYPS08E3qfflxPd+mKd1h0BF7M= X-Google-Smtp-Source: AMsMyM6nv5J2Q62J7r3Xp6TlfR7BXge0gyJGUO0xXQuhwUbsMct7VLmKW2RclsXFKYqJjiiPVEDTdg== X-Received: by 2002:a65:674e:0:b0:43c:3b91:236e with SMTP id c14-20020a65674e000000b0043c3b91236emr27286795pgu.510.1664962456118; Wed, 05 Oct 2022 02:34:16 -0700 (PDT) Received: from ?IPV6:2001:f40:91b::4156? ([2001:f40:91b::4156]) by smtp.gmail.com with ESMTPSA id n16-20020a170902f61000b0017691eb7e17sm10096255plg.239.2022.10.05.02.34.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 02:34:15 -0700 (PDT) Message-ID: <2bdafbbd-9073-aa4e-30bb-2c7d2c7065c5@gmail.com> Date: Wed, 5 Oct 2022 09:34:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] testsuite: /dev/null is not accessible on Windows Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220929173809.2234264-1-torbjorn.svensson@foss.st.com> From: Jonathan Yong <10walls@gmail.com> In-Reply-To: <20220929173809.2234264-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3040.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote: > When running the DejaGNU testsuite on a toolchain built for native > Windows, the path /dev/null can't be used to open a stream to void. > On native Windows, the resource is instead named "nul". > > The error would look like this: > c:/arm-11.3.rel1/bin/../lib/gcc/arm-none-eabi/11.3.1/../../../../arm-none-eabi/bin/ld.exe: cannot find @/dev/null: No such file or directory > > Patch has been verified on Windows and Linux. > > gcc/testsuite: > > * gcc.misc-tests/outputs.exp: Use "@nul" for Windows, > "@/dev/null" for other environments. > > Co-Authored-By: Yvan ROUX > Signed-off-by: Torbjörn SVENSSON > --- > gcc/testsuite/gcc.misc-tests/outputs.exp | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp > index ab919db1ccb..3fe7270fa63 100644 > --- a/gcc/testsuite/gcc.misc-tests/outputs.exp > +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp > @@ -78,6 +78,13 @@ if {[board_info $dest exists output_format]} { > append link_options " additional_flags=-Wl,-oformat,[board_info $dest output_format]" > } > > + > +set devnull "/dev/null" > +if { [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } { > + # Windows uses special file named "nul" as a substitute for /dev/null > + set devnull "nul" > +} > + > # Avoid possible influence from the make jobserver, > # otherwise ltrans0.ltrans_args files may be missing. > if [info exists env(MAKEFLAGS)] { > @@ -353,10 +360,10 @@ outest "$b-21 exe savetmp named2" $mult "-o $b.exe -save-temps" {} {{--1.i --1.s > > # Additional files are created when an @file is used > if !$skip_atsave { > -outest "$b-22 exe savetmp namedb-2" $sing "@/dev/null -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}} > -outest "$b-23 exe savetmp named2-2" $mult "@/dev/null -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}} > -outest "$b-24 exe savetmp named2-3" $mult "@/dev/null -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}} > -outest "$b-25 exe savetmp named2-4" $mult "@/dev/null -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}} > +outest "$b-22 exe savetmp namedb-2" $sing "@$devnull -o $b.exe -save-temps" {} {{--0.i --0.s --0.o .args.0 !!$gld .ld1_args !0 .exe}} > +outest "$b-23 exe savetmp named2-2" $mult "@$devnull -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o .args.0 !!$gld .ld1_args !0 .exe}} > +outest "$b-24 exe savetmp named2-3" $mult "@$devnull -I dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 !!$gld .ld1_args !0 .exe}} > +outest "$b-25 exe savetmp named2-4" $mult "@$devnull -I dummy -L dummy -o $b.exe -save-temps" {} {{--1.i --1.s --1.o --2.i --2.s --2.o -args.0 -args.1 .args.2 .args.3 !!$gld .ld1_args !0 .exe}} > } > > # Setting the main output to a dir selects it as the default aux&dump > @@ -714,7 +721,7 @@ outest "$b-291 lto mult named-2" $mult "-o $b.exe -O2 -flto -fno-use-linker-plug > outest "$b-292 lto sing nameddir-2" $sing "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--0.c.???i.icf --0.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}} > outest "$b-293 lto mult nameddir-2" $mult "-o dir/$b.exe -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage" {dir/} {{--1.c.???i.icf --1.c.???r.final --2.c.???i.icf --2.c.???r.final .wpa.???i.icf .ltrans0.ltrans.???r.final .ltrans0.ltrans.su .exe} {}} > if !$skip_atsave { > -outest "$b-294 lto sing unnamed-3" $sing "@/dev/null -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}} > +outest "$b-294 lto sing unnamed-3" $sing "@$devnull -O2 -flto -fno-use-linker-plugin -flto-partition=one -fdump-ipa-icf-optimized -fdump-rtl-final -fstack-usage -save-temps $oaout" {} {{a--0.c.???i.icf a--0.c.???r.final a.wpa.???i.icf a.ltrans0.ltrans.???r.final a.ltrans0.ltrans.su a--0.o a--0.s a--0.i a.ltrans0.o a.ltrans.out a.ltrans0.ltrans.o a.ltrans0.ltrans_args a.args.0 a.ltrans0.ltrans.s a.wpa.args.0 a.lto_args a.ld1_args a.ltrans_args a.ltrans0.ltrans.args.0 a.ld_args $aout}} > } > } > Thanks, looks good to me, will push to master soon.