From: Bernd Schmidt <bschmidt@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [0/3] Fix PR78120, in ifcvt/rtlanal/i386.
Date: Wed, 23 Nov 2016 19:00:00 -0000 [thread overview]
Message-ID: <2bde94e0-b470-8aad-6a9c-91e45dc8b687@redhat.com> (raw)
In-Reply-To: <e6d06b7a-831b-299a-5c5a-507e267238a4@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
Note that I misspelled the PR number in the 0/3 message :-/
On 11/23/2016 07:57 PM, Bernd Schmidt wrote:
> 1. I noticed comparisons between set_src_cost and set_rtx_cost seemed to
> be invalid. There seems to be no good reason that insn_rtx_cost
> shouldn't use the latter. It also makes the numbers comparable to the
> ones you get from seq_cost.
Bernd
[-- Attachment #2: 71280-1.diff --]
[-- Type: text/x-patch, Size: 480 bytes --]
PR rtl-optimization/78120
* rtlanal.c (insn_rtx_cost): Use set_rtx_cost.
Index: gcc/rtlanal.c
===================================================================
--- gcc/rtlanal.c (revision 242038)
+++ gcc/rtlanal.c (working copy)
@@ -5211,7 +5211,7 @@ insn_rtx_cost (rtx pat, bool speed)
else
return 0;
- cost = set_src_cost (SET_SRC (set), GET_MODE (SET_DEST (set)), speed);
+ cost = set_rtx_cost (set, speed);
return cost > 0 ? cost : COSTS_N_INSNS (1);
}
next prev parent reply other threads:[~2016-11-23 19:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 18:58 [0/3] Fix PR71280, " Bernd Schmidt
2016-11-23 19:00 ` Bernd Schmidt [this message]
2016-11-23 19:30 ` [0/3] Fix PR78120, " Jeff Law
2016-11-23 19:31 ` Bernd Schmidt
2016-11-24 14:21 ` Segher Boessenkool
2016-11-24 14:26 ` Bernd Schmidt
2016-11-24 14:36 ` Segher Boessenkool
2016-11-24 14:38 ` Bernd Schmidt
2016-11-24 14:44 ` Eric Botcazou
2016-11-24 14:54 ` Segher Boessenkool
2016-11-24 15:16 ` Richard Biener
2016-11-24 15:46 ` Jeff Law
2016-11-24 15:34 ` Bernd Schmidt
2016-11-24 15:48 ` Jeff Law
2016-11-24 16:14 ` Segher Boessenkool
2016-11-24 22:32 ` Segher Boessenkool
2016-11-26 10:44 ` Jeff Law
2016-11-26 11:11 ` Eric Botcazou
2016-11-26 16:15 ` Jeff Law
2016-11-26 22:03 ` Segher Boessenkool
2016-11-26 18:08 ` Segher Boessenkool
2016-11-25 9:15 ` Richard Biener
2016-11-25 15:34 ` Jeff Law
2016-11-25 15:55 ` Segher Boessenkool
2016-11-28 8:59 ` Bernd Schmidt
2016-11-28 9:05 ` Bernd Schmidt
2016-11-28 18:50 ` Jeff Law
2016-11-28 18:52 ` Bernd Schmidt
2016-11-23 19:01 ` Bernd Schmidt
2016-11-23 21:46 ` Uros Bizjak
2016-11-23 19:03 ` [3/3] " Bernd Schmidt
2016-11-23 19:38 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bde94e0-b470-8aad-6a9c-91e45dc8b687@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).