From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BDCEA385BAED for ; Fri, 24 Jun 2022 18:25:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDCEA385BAED Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-501-Sb_gSPCNOFW2ofNlRe20Dw-1; Fri, 24 Jun 2022 14:25:40 -0400 X-MC-Unique: Sb_gSPCNOFW2ofNlRe20Dw-1 Received: by mail-qv1-f69.google.com with SMTP id w18-20020a0ce112000000b0046e7f2c5a06so3374641qvk.0 for ; Fri, 24 Jun 2022 11:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=WHMk1lT5hBu/wC8s9vMybF7OmLlgCb30KxEuep9MKRE=; b=dxYrt24jwL5YbWNIo+QaRT4Ya/0hY++CAqEnPJT7jpwF0oM27CA50UgqTnjzXlK2kD QJ/ZCU4WtTdm9Bk/l3SKeSOFtNFXTRlk8LhvXXb4YgSJh96P06jxLreYPLikelySe/bF iTHUbxxLSIHudU9/VLxSm4LMMwAzQfBIfoLCySAExRHDPyLJPW0Dzl2CWZPehQjfwoQl zXGQ7WqL66edMVvIu3YUxavskYyuijG74kl0z9N9jbNDo0Ran3Ex/c6anOgQmtUkD0AN N8f+osS7IEr4sWQ6zBRYGFZGLyQJ7+vJpkJ+TMiXv3LY63DtlLcda2Pve4hh4QuhgZI5 lStA== X-Gm-Message-State: AJIora/qBGsSKeeHGndC7tdzArA+PtK2N5tC822GZKlGViDVwHqhj9b+ I9R0CinBSbpaeqPS/S47NTseN/gCKiKM4WuInDA61x7TYndvxtcoRY6VB8QfbImgKXI64MPRvan PTF7AwuRZkVR8+ZdglQ== X-Received: by 2002:ac8:7f44:0:b0:305:3353:4111 with SMTP id g4-20020ac87f44000000b0030533534111mr223261qtk.349.1656095139383; Fri, 24 Jun 2022 11:25:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXCaGV4RPVAVW9gztdSZ31bob0xsBRej2MGho1H+5vEX0VpRtue6N7tuq11KZPH8z1BAWRzA== X-Received: by 2002:ac8:7f44:0:b0:305:3353:4111 with SMTP id g4-20020ac87f44000000b0030533534111mr223248qtk.349.1656095139162; Fri, 24 Jun 2022 11:25:39 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id l2-20020a05620a28c200b006a6cadd89efsm2678877qkp.82.2022.06.24.11.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 11:25:38 -0700 (PDT) Message-ID: <2bf3f5270abb8c42f035f33615157af8a81d2ca9.camel@redhat.com> Subject: Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0 From: David Malcolm To: Lewis Hyatt , gcc-patches@gcc.gnu.org, Joseph Myers Date: Fri, 24 Jun 2022 14:25:37 -0400 In-Reply-To: <20220606214957.GA58074@ldh-imac.local> References: <20220606214957.GA58074@ldh-imac.local> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 18:25:42 -0000 On Mon, 2022-06-06 at 17:49 -0400, Lewis Hyatt via Gcc-patches wrote: > Hello- > > The attached patch upgrades the cpp_wcwidth() function (needed for > computing display columns in diagnostics output) from Unicode 13 to > Unicode 14. I just mechanically followed the procedure in > contrib/unicode/README with nothing unexpected coming up. I attached it > compressed since it's a bit large, and not really human readable > anyway. Please let me know if it's OK to commit. I did > bootstrap/regtest > all languages with no issues on x86-64 Linux. (Although I had to revert > locally one unrelated commit that seems to break bootstrap for Ada on > the > master branch currently.) > > BTW, is this something simple enough I should just commit it without > bugging > the list for approval? The patch seems reasonable to me, but Joseph seems to be the expert on i18n-related matters. Joseph, do we have a policy on this? Thanks Dave > > Thanks! > > -Lewis > > ====== > > Subject: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0 > > The procedure detailed in contrib/unicode/README was followed with > nothing > notable coming up. The glibc scripts did not require any update, so the > only change was retrieving new versions of the Unicode data files and > rerunning gen_wcwidth.py. > > contrib/ChangeLog: > >         * unicode/EastAsianWidth.txt: Update to Unicode 14.0.0. >         * unicode/PropList.txt: Likewise. >         * unicode/README: Likewise. >         * unicode/UnicodeData.txt: Likewise. > > libcpp/ChangeLog: > >         * generated_cpp_wcwidth.h: Generated from updated Unicode data > files.