From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 209B0385840D for ; Tue, 19 Dec 2023 17:40:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 209B0385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 209B0385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703007643; cv=none; b=M35x/hduURBLK3auSJyLS9WHYbaRqDMzDFQ1b0zs9Oq1++H343pRwOqo6hhadfe5QYp1zhJflj95188adCjxY2IEbMR1om6ynnPtUQ3m6ZAZzyohUH6MRGYgSHyi+eN1H0SbOYSLWf/cupZzMKfPF5Oia/zdmhaszGUiLHUVlc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703007643; c=relaxed/simple; bh=j9WvtpWu8uu6NNYK6jCuB8YrW/fhGpna6E33EWgg1Jo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=rm+FaqcILeDn6ZcvJe7jwdx/gD2dPg9zbdBsuNb+Vg2tUW8Y/yIP0EPNQuNYGEF31GV5U+sPTMwaEBFMr5uKV9+E804gSMsLsIuJF2llrb/0v9wVmGu/t3KSgIqnc+XIYVmLoxjv3WmfuVIOlMtnCjoMx34g6IPTCAeS+CTYzgU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703007641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BRVZc4slXyL1dGH4zi2BAZ9t3WsSw6xRs+EBLKlJdyE=; b=aI2Dunhqrxn9oH223VDeggCqRdtJlUfCmYbpCzuK/1SVwmwln3zUrIwuBd+fYiCp+997Go 07HYB23srTe5FySfG3cxIzoWHpYCm1xCufSCdpbzWlt0urSMX3AjIaHq74NAjxhQB2S9Tu 5HEFSxlEzvvbM9mNH6SOTvdTi4JoMdY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-KKkiqg1iMeK1y1r9a1ojNw-1; Tue, 19 Dec 2023 12:40:40 -0500 X-MC-Unique: KKkiqg1iMeK1y1r9a1ojNw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-77f4b757646so455705885a.2 for ; Tue, 19 Dec 2023 09:40:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703007639; x=1703612439; h=content-transfer-encoding:in-reply-to:cc:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRVZc4slXyL1dGH4zi2BAZ9t3WsSw6xRs+EBLKlJdyE=; b=s44TAOaeC5G1Q52QZiNp8e/oMdylxUZAchQzpjNYKkAPHY0rr+anDQr19ej2qVzk/S N9OlPDdkjIaxE9n6Zn5IoVUOcAQlGpTkGgTM/yvr99ojrw/2myBVkjh941M8qnLMnJkh CdxcjO9C21vsTCKpqzy5uMmvINgy85EqrOZ/DDiuKK7hNtOIb82x+o9aVkoWA+P9zLvG Uev3rghWWKvuB6YAHo0Yuf8YIwn7oQYJXgo/wSue/PnBVSxgw75T1oqdSgAjlytuQ5xg We1hH319iy4Q8/p7df5Z8gT6TJwuYzC2SP3Qeluwcp2j64ex24Ipk9lMae2Vht0OGKaq 1Y3Q== X-Gm-Message-State: AOJu0YwQ6PNzsdl2jJOMFwbubQ2V1dHrmsUvTVlDA+HWR9J084KO24zH 8IVLU7GDtV5McFpUpIunCD+EMXycqVtFhd0UekZ6Jb3/k+auTqQLoNW7jWIWGj6yzbjAiVrJy3d nKQ6mcLPIkesswUp3y/KPa4lOxdKkqztAKj/XfxqPbKfUWSVnWrOE1I97ptPAbbITwqEb4VCtnw == X-Received: by 2002:a05:620a:51c4:b0:781:6ec:247d with SMTP id cx4-20020a05620a51c400b0078106ec247dmr810248qkb.55.1703007639236; Tue, 19 Dec 2023 09:40:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7rsFA6b1JfEZiMo9pdGUY4BDZ0LqhoXRVx83ZivGwA4Hf2RWuoQPWMPAMZ4Jh3VJxZWM+eg== X-Received: by 2002:a05:620a:51c4:b0:781:6ec:247d with SMTP id cx4-20020a05620a51c400b0078106ec247dmr810241qkb.55.1703007638921; Tue, 19 Dec 2023 09:40:38 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id a31-20020a05620a439f00b0077d66277e9asm9263757qkp.116.2023.12.19.09.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 09:40:38 -0800 (PST) Message-ID: <2bfeed48-e237-4dcb-802e-1acc111ff69b@redhat.com> Date: Tue, 19 Dec 2023 12:40:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Ping Re: [PATCH] contrib: add git gcc-style alias From: Jason Merrill To: gcc-patches@gcc.gnu.org References: <20231212030031.1023808-1-jason@redhat.com> Cc: Alexandre Oliva In-Reply-To: <20231212030031.1023808-1-jason@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/11/23 22:00, Jason Merrill wrote: > OK for trunk? Ping. CCing Alex because this could plausibly be considered build machinery, and he's had useful feedback on my sh code before. > -- 8< -- > > I thought it could be easier to use check_GNU_style.py. With this alias, > 'git gcc-style' will take a git revision as argument instead of a file, or > check HEAD if no argument is given. > > contrib/ChangeLog: > > * gcc-git-customization.sh: Add git gcc-style alias. > --- > contrib/gcc-git-customization.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh > index 2e173e859d7..54bd35ea1aa 100755 > --- a/contrib/gcc-git-customization.sh > +++ b/contrib/gcc-git-customization.sh > @@ -30,6 +30,11 @@ git config alias.gcc-backport '!f() { "`git rev-parse --show-toplevel`/contrib/g > git config alias.gcc-fix-changelog '!f() { "`git rev-parse --show-toplevel`/contrib/git-fix-changelog.py" $@; } ; f' > git config alias.gcc-mklog '!f() { "`git rev-parse --show-toplevel`/contrib/mklog.py" $@; } ; f' > git config alias.gcc-commit-mklog '!f() { "`git rev-parse --show-toplevel`/contrib/git-commit-mklog.py" "$@"; }; f' > +git config alias.gcc-style '!f() { > + check=`git rev-parse --show-toplevel`/contrib/check_GNU_style.py; > + arg=; if [ $# -ge 1 ] && [ "$1" != "-f" ]; then arg="$1"; shift; > + elif [ $# -eq 3 ]; then arg="$3"; set -- "$1" "$2"; fi > + git show $arg | $check "$@" -; }; f' > > # Make diff on MD files use "(define" as a function marker. > # Use this in conjunction with a .gitattributes file containing > > base-commit: 074c6f15f7a28c620c756f18c2a310961de00539