Re: [PATCH] c++: improve class NTTP object pretty printing [PR111471]

[Jason Merrill <jason@redhat.com>]

On 9/20/23 10:13, Patrick Palka wrote:
> On Tue, 19 Sep 2023, Patrick Palka wrote:
> 
>> On Tue, 19 Sep 2023, Jason Merrill wrote:
>>
>>> On 9/19/23 12:40, Patrick Palka wrote:
>>>> Tested on x86_64-pc-linux-gnu, does this look OK for trunk/13?
>>>
>>> OK for trunk.  What's your argument for backporting?
>>
>> Thanks.  I don't feel strongly about it, but I was thinking that since
>> we typically backport C++20-only correctness fixes to the most recent
>> release branch, C++20-only diagnostic improvements might be suitable
>> too?
>>
>>>
>>>> -- >8 --
>>>>
>>>> 1. Move class NTTP object pretty printing to a more general spot in
>>>>      the pretty printer.
> 
> FWIW this first change isn't just a refactoring, it means we now pretty
> print an NTTP object that appears elsewhere besides in a template
> argument list, e.g. in a parameter mapping:
> 
> Before:
> 
> diagnostic19.C:8:15: note: the expression ‘((const A)V).value [with V = _ZTAXtl1AEE]’ evaluated to ‘false’
> 
> After:
> 
> diagnostic19.C:8:15: note: the expression ‘(V).value [with V = A{false}]’ evaluated to ‘false’

Ah, that is a pretty big improvement.  The patch is OK.

Jason