From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CED513858C42 for ; Tue, 16 Jan 2024 20:24:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CED513858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CED513858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705436659; cv=none; b=vbfhAx6yladPGRXrrniYLdHTzoTQRhT3wOm2rLg7mmKNLNXr+sfX6cymN/9j2buwKcqnud/PAhNKJZ5jdyz+54UaeY8WGvrYD/LJbiURVqdmBbbyaIq0As2OKaR1HzAXB6fP7V27xhBsyk89Av6ZqeXlB97OTfCsMpw6KqCbjlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705436659; c=relaxed/simple; bh=nHvcjGbsWNN0Pay1BmgDP+foXqSrdw2QD9GinDXdFgA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t6sQ6+PT/LIfXYZF1J2VoEnmav7MCLxL+9+/ROfbcqjk/lK6OoJkUYydFElhCJHnt1GtzHie4duQ6CpmnBE70Mu5cYLsJkO9DCwRWzUNYkNZSgb2Oy9bQxUAoKQ7zJCvvEF38vJjUO7gXBFSODD4THHxVBx7GeS9Xe+0bMyX6eQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705436657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=leFqmJ8OBH4EmW/MdRR1tP0uylRextbb/4LChnEe46g=; b=XSbMhsTIpW+pEik5+Ibklohujiw0b9iERrLiw6rs42+/8SiX5K5SorUneGZSMK5kYoCpHw 8+GMG3Ix74D0nfbkYRQR1OmkNfL35WcUDPTxGFU21rB7PUgz0HjHJbmLiZb2HtORGzVN5t arFZW6Tpq1+gfBiaiRsQFxXApwyeChs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-se5oF7diMr-Tn87WuVejaQ-1; Tue, 16 Jan 2024 15:24:16 -0500 X-MC-Unique: se5oF7diMr-Tn87WuVejaQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-68178b82930so5180906d6.2 for ; Tue, 16 Jan 2024 12:24:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705436655; x=1706041455; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=leFqmJ8OBH4EmW/MdRR1tP0uylRextbb/4LChnEe46g=; b=CY/7CMJllR+7L11i2bjx7DhwbfRHQIZaoAv4kvPJFq7+UsnB8UVDLdFWwwn8jTX1Ub adE1nLHSiQubmw43e/aVzJXGXEIBe53mIRBykfUeVgpcsJWhhem5BZXgt9CvEyFfPI8i BRw6IYu74xpCFq38VhWkY912zcxxKnve0bCLN6LPWxdSyd5yUzbJRmZ+Q3jOdOA5o5Ms UEceWdt3checZwzh9IKMC33krE7OdZl8FXtBelcJWpbNm/hDTN2s3kYhLu5VjYiOqmoT jDBB74q+hh73Tk3jSZydizLWazuk9YL3gucIQ7SoyRiL5DSbLU/lj9xHZsIFQF4G/Y5F xzxA== X-Gm-Message-State: AOJu0YzUZBje2kJ465XSCkjqP+YKo1K9iM8v6vglMCpMmAE/p9tE5y8k 4u/SvRAyG9gxLUPtQXgKyGD4LwGH3LBMbBIHNhCJXeZ2dlNEKWjfuK9+y+4oJHpd3GCGzVw4e0d bb32c/Mcc/HJhY5cSFZOkf5z3Fti25sc0tQ== X-Received: by 2002:a0c:ca0f:0:b0:681:73f2:9f63 with SMTP id c15-20020a0cca0f000000b0068173f29f63mr1111231qvk.72.1705436655576; Tue, 16 Jan 2024 12:24:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDt6qFH+dK3NLu6CVhqekbONe/7ZNEYzMeAmT2TONatlBhIk8wlo3EVvu8dJOIc9Wa1C3fVA== X-Received: by 2002:a0c:ca0f:0:b0:681:73f2:9f63 with SMTP id c15-20020a0cca0f000000b0068173f29f63mr1111223qvk.72.1705436655312; Tue, 16 Jan 2024 12:24:15 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id d2-20020a0cf0c2000000b00680d2247031sm4430315qvl.81.2024.01.16.12.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 12:24:14 -0800 (PST) Message-ID: <2cb2811a-f7d1-48eb-b1fb-724a35fe53d1@redhat.com> Date: Tue, 16 Jan 2024 15:24:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] cp: Use get_mangled_id in more places in mangle_decl To: Andrew Carlotti , gcc-patches@gcc.gnu.org Cc: Richard Biener References: <8f8d566a-df83-8562-0420-cb01592ad98c@e124511.cambridge.arm.com> From: Jason Merrill In-Reply-To: <8f8d566a-df83-8562-0420-cb01592ad98c@e124511.cambridge.arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/15/24 06:28, Andrew Carlotti wrote: > There's no functional change here, but it makes it clearer that all > three locations should be doing the same thing (aside from changes to > flag_abi_version). OK. > gcc/cp/ChangeLog: > > * mangle.cc (mangle_decl): Consistently use get_mangled_id. > > > diff --git a/gcc/cp/mangle.cc b/gcc/cp/mangle.cc > index a04bc584586f28cb80d21b5c6d647416aa8843df..9bd684608b9e3378292cdb042184ba603b3d69aa 100644 > --- a/gcc/cp/mangle.cc > +++ b/gcc/cp/mangle.cc > @@ -4503,8 +4503,7 @@ mangle_decl (const tree decl) > return; > > flag_abi_version = flag_abi_compat_version; > - id2 = mangle_decl_string (decl); > - id2 = targetm.mangle_decl_assembler_name (decl, id2); > + id2 = get_mangled_id (decl); > flag_abi_version = save_ver; > > if (id2 != id) > @@ -4519,8 +4518,7 @@ mangle_decl (const tree decl) > || id2 == NULL_TREE) > { > flag_abi_version = warn_abi_version; > - id2 = mangle_decl_string (decl); > - id2 = targetm.mangle_decl_assembler_name (decl, id2); > + id2 = get_mangled_id (decl); > } > flag_abi_version = save_ver; > >