From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id BDF643858C20 for ; Mon, 25 Jul 2022 06:09:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDF643858C20 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26P5llxg027164; Mon, 25 Jul 2022 06:09:15 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hhnbfgfkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 06:09:14 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26P5sMbp017351; Mon, 25 Jul 2022 06:09:14 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hhnbfgfk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 06:09:14 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26P66AMx019993; Mon, 25 Jul 2022 06:09:12 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 3hg95y9f16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 06:09:12 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26P69NZx32375122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Jul 2022 06:09:23 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB3454C046; Mon, 25 Jul 2022 06:09:09 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37FB24C040; Mon, 25 Jul 2022 06:09:08 +0000 (GMT) Received: from [9.200.45.126] (unknown [9.200.45.126]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 25 Jul 2022 06:09:07 +0000 (GMT) Content-Type: multipart/mixed; boundary="------------qcI3UHh5dfEvjEoZFIpB1IcU" Message-ID: <2cc2ed52-98a2-570e-23ab-c01487b49b13@linux.ibm.com> Date: Mon, 25 Jul 2022 14:09:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000/test: Update some cases with -mdejagnu-tune Content-Language: en-US To: Peter Bergner , Segher Boessenkool Cc: GCC Patches , David Edelsohn References: <4847b51d-dde2-916b-27aa-8e63518d66d2@linux.ibm.com> <20220721184806.GK25951@gate.crashing.org> <11061a26-e6db-2f61-065e-b1c9a32d3181@linux.ibm.com> <20220722181712.GO25951@gate.crashing.org> <7b179407-cb97-f86d-0948-00d5a67f2cb4@linux.ibm.com> <3f076f76-86e5-0033-4d0d-45c6e8f119eb@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <3f076f76-86e5-0033-4d0d-45c6e8f119eb@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: EMHFAbaK3-6M-hGNOMZnAzAE5qmxJUNN X-Proofpoint-ORIG-GUID: 0xJfXsNH9BTI-9hWPZ2bO67-JN8WEsh9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-23_02,2022-07-21_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 mlxscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207250026 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 06:09:17 -0000 This is a multi-part message in MIME format. --------------qcI3UHh5dfEvjEoZFIpB1IcU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Peter and Segher, on 2022/7/23 03:28, Peter Bergner wrote: > On 7/22/22 1:53 PM, Peter Bergner wrote: >> So I think the way the code above *should* work is: >> 1) Any -mdejagnu-cpu= usage should filter out all -mcpu= and -mtune= options. >> 2) Any -mdejagnu-tune= usage should filter all -mtune= options. >> It should not filter out any -mcpu= options. > > Like this: > > diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h > index 3b8941a8658..26874943795 100644 > --- a/gcc/config/rs6000/rs6000.h > +++ b/gcc/config/rs6000/rs6000.h > @@ -86,7 +86,7 @@ > RUNTESTFLAGS override those set in the testcases; with this option, > the testcase will always win. Ditto for -mdejagnu-tune=. */ > #define DRIVER_SELF_SPECS \ > - "%{mdejagnu-cpu=*: % + "%{mdejagnu-cpu=*: % "%{mdejagnu-tune=*: % "%{mdejagnu-*: % SUBTARGET_DRIVER_SELF_SPECS > > > Kewen, can you see if the above patch fixes the issues you're seeing? > Thanks for the insightful comments and patch! I confirmed that this proposed patch can fix those found test issues. I adjusted the relevant comments and confirmed that it can be bootstrapped and regtested on powerpc64-linux-gnu P7 and P8 and powerpc64le-linux-gnu P9 and P10. Segher pre-approved it, I just committed it as r13-1818 as attached. Will backport it to release branches in a week or so. Thanks again. BR, Kewen --------------qcI3UHh5dfEvjEoZFIpB1IcU Content-Type: text/plain; charset=UTF-8; name="0001-rs6000-Adjust-mdejagnu-cpu-to-filter-out-mtune-PR106.patch" Content-Disposition: attachment; filename*0="0001-rs6000-Adjust-mdejagnu-cpu-to-filter-out-mtune-PR106.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3NWQyMGQ2Yzg0YzEyYmVkZDY1YTkwNGU0NjJmMDJmMGI5ZWIzZjc3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBCZXJnbmVyIDxiZXJnbmVyQGxpbnV4Lmli bS5jb20+CkRhdGU6IE1vbiwgMjUgSnVsIDIwMjIgMDA6NTE6NDQgLTA1MDAKU3ViamVjdDog W1BBVENIXSByczYwMDA6IEFkanVzdCAtbWRlamFnbnUtY3B1IHRvIGZpbHRlciBvdXQgLW10 dW5lIFtQUjEwNjM0NV0KCkFzIFBSMTA2MzQ1IHNob3dzLCB3aGVuIGNvbmZpZ3VyaW5nIGNv bXBpbGVyIHdpdGggYW4gZXhwbGljaXQKb3B0aW9uIC0td2l0aC10dW5lPTx2YWx1ZT4sIGl0 IHdvdWxkIGNhdXNlIHNvbWUgdGVzdCBjYXNlcyB0bwpmYWlsIGlmIHRoZWlyIHRlc3QgcG9p bnRzIGFyZSBzZW5zaXRpdmUgdG8gdHVuZSBzZXR0aW5nLCBzdWNoCmFzOiBncm91cF9lbmRp bmdfbm9wLCBsb29wIGFsaWduIGV0Yy4gIEl0IGRvZXNuJ3QgaGVscCB0aGF0CmV2ZW4gdG8g c3BlY2lmeSBvbmUgZXhwbGljaXQgLW1jcHU9LgoKVGhpcyBwYXRjaCBpcyB0byBhZGp1c3Qg dGhlIGJlaGF2aW9yIG9mIC1tZGVqYWdudS1jcHUgYnkKZmlsdGVyaW5nIG91dCBhbGwgLW1j cHU9IGFuZCAtbXR1bmU9IG9wdGlvbnMsIHRoZW4gdGVzdCBjYXNlcwp3b3VsZCB1c2UgPGNw dT4gYXMgdHVuZSBhcyB0aGUgb25lIHNwZWNpZmllZCBieSAtbWRlamFnbnUtY3B1LgoKMjAy Mi0wNy0yNSAgUGV0ZXIgQmVyZ25lciAgPGJlcmduZXJAbGludXguaWJtLmNvbT4KCSAgICBL ZXdlbiBMaW4gIDxsaW5rd0BsaW51eC5pYm0uY29tPgoKCVBSIHRlc3RzdWl0ZS8xMDYzNDUK CmdjYy9DaGFuZ2VMb2c6CgoJKiBjb25maWcvcnM2MDAwL3JzNjAwMC5oIChEUklWRVJfU0VM Rl9TUEVDUyk6IEFkanVzdCAtbWRlamFnbnUtY3B1Cgl0byBmaWx0ZXIgb3V0IGFsbCAtbXR1 bmUgb3B0aW9ucy4KLS0tCiBnY2MvY29uZmlnL3JzNjAwMC9yczYwMDAuaCB8IDExICsrKysr KystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2djYy9jb25maWcvcnM2MDAwL3JzNjAwMC5oIGIvZ2NjL2NvbmZp Zy9yczYwMDAvcnM2MDAwLmgKaW5kZXggN2QwNDU1NjMwNGEuLmFkOWJmMGY3MzU4IDEwMDY0 NAotLS0gYS9nY2MvY29uZmlnL3JzNjAwMC9yczYwMDAuaAorKysgYi9nY2MvY29uZmlnL3Jz NjAwMC9yczYwMDAuaApAQCAtODEsMTIgKzgxLDE1IEBACiAjIGRlZmluZSBTVUJUQVJHRVRf RFJJVkVSX1NFTEZfU1BFQ1MgIiIKICNlbmRpZgogCi0vKiBPbmx5IGZvciB1c2UgaW4gdGhl IHRlc3RzdWl0ZTogLW1kZWphZ251LWNwdT0gc2ltcGx5IG92ZXJyaWRlcyAtbWNwdT0uCisv KiBPbmx5IGZvciB1c2UgaW4gdGhlIHRlc3RzdWl0ZTogLW1kZWphZ251LWNwdT08dmFsdWU+ IGZpbHRlcnMgb3V0IGFsbAorICAgLW1jcHU9IGFzIHdlbGwgYXMgLW10dW5lPSBvcHRpb25z IHRoZW4gc2ltcGx5IGFkZHMgLW1jcHU9PHZhbHVlPiwKKyAgIHdoaWxlIC1tZGVqYWdudS10 dW5lPTx2YWx1ZT4gZmlsdGVycyBvdXQgYWxsIC1tdHVuZT0gb3B0aW9ucyB0aGVuCisgICBz aW1wbHkgYWRkcyAtbXR1bmU9PHZhbHVlPi4KICAgIFdpdGggb2xkZXIgdmVyc2lvbnMgb2Yg RGVqYWdudSB0aGUgY29tbWFuZCBsaW5lIGFyZ3VtZW50cyB5b3Ugc2V0IGluCi0gICBSVU5U RVNURkxBR1Mgb3ZlcnJpZGUgdGhvc2Ugc2V0IGluIHRoZSB0ZXN0Y2FzZXM7IHdpdGggdGhp cyBvcHRpb24sCi0gICB0aGUgdGVzdGNhc2Ugd2lsbCBhbHdheXMgd2luLiAgRGl0dG8gZm9y IC1tZGVqYWdudS10dW5lPS4gICovCisgICBSVU5URVNURkxBR1Mgb3ZlcnJpZGUgdGhvc2Ug c2V0IGluIHRoZSB0ZXN0Y2FzZXM7IHdpdGggdGhlc2Ugb3B0aW9ucywKKyAgIHRoZSB0ZXN0 Y2FzZSB3aWxsIGFsd2F5cyB3aW4uICAqLwogI2RlZmluZSBEUklWRVJfU0VMRl9TUEVDUyBc Ci0gICIle21kZWphZ251LWNwdT0qOiAlPG1jcHU9KiAtbWNwdT0lKn0iLCBcCisgICIle21k ZWphZ251LWNwdT0qOiAlPG1jcHU9KiAlPG10dW5lPSogLW1jcHU9JSp9IiwgXAogICAiJXtt ZGVqYWdudS10dW5lPSo6ICU8bXR1bmU9KiAtbXR1bmU9JSp9IiwgXAogICAiJXttZGVqYWdu dS0qOiAlPG1kZWphZ251LSp9IiwgXAogICAgU1VCVEFSR0VUX0RSSVZFUl9TRUxGX1NQRUNT Ci0tIAoyLjI1LjEKCg== --------------qcI3UHh5dfEvjEoZFIpB1IcU--