From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93922 invoked by alias); 7 Dec 2018 15:06:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93884 invoked by uid 89); 7 Dec 2018 15:06:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,LIKELY_SPAM_BODY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Earnshaw, earnshaw X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Dec 2018 15:06:35 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A8E1230A5A76; Fri, 7 Dec 2018 15:06:33 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-17.rdu2.redhat.com [10.10.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id E47186F7E0; Fri, 7 Dec 2018 15:06:32 +0000 (UTC) Subject: Re: [committed] PR testsuite/86540, twiddle for aarch64 To: "Richard Earnshaw (lists)" , gcc-patches References: From: Jeff Law Openpgp: preference=signencrypt Message-ID: <2ccb1968-2c73-1b8f-f995-dedcee929477@redhat.com> Date: Fri, 07 Dec 2018 15:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00463.txt.bz2 On 12/7/18 6:46 AM, Richard Earnshaw (lists) wrote: > On 06/12/2018 15:36, Jeff Law wrote: >> >> As outlined in the PR, the aarch64 has a non-default value for >> CASE_VALUES_THRESHOLD which changes decisions in switch lowering. Those >> changes in switch lowering can expose additional jump threads later in >> the pipeline which cause heartburn for a couple tests. >> >> I looked at all the other ports with a non-default value of >> CASE_VALUES_THRESHOLD and only aarch64 is high enough to trigger these >> changes in behavior on the two relevant tests. So I'm just skipping the >> tests that run after switch lowering on aarch64. >> >> Verified with a cross that these tests now pass. >> >> Committing to the trunk, >> > > Can't we use a param to force the value back to (near) the default? > That would then work even if other targets start changing the default here. That would have been my preference, but I didn't see a suitable PARAM and adding one just for these two tests seemed like overkill. jeff