From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id E124C3858C54 for ; Thu, 23 Nov 2023 07:11:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E124C3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E124C3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700723481; cv=none; b=WVsE6wARPg4pSD1QlUCmIxLxrpMiwdYvZO7ugx/dVt1dUI770G/+U9GOxXMbPbP+lLagaWPqW1T3gHnGqVoMoiy7aRE4b2WBS4OfVIfbQZEi9AdoFEiueJjjI/zW965SZ2k4rpxMHvxzOH2cYhJsN4EMZgb4fHD/5V1w1Xps6PY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700723481; c=relaxed/simple; bh=V/OALe/+QNK8qQbB8ii86gqUYRKt5b0ZND9ITXxgTJ4=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=re3sYdCBSEwbtkkK/b8gQVkJC+jQ6nvd48PWwy9QIyGb5HCC9CPN9B/EEe2C/vz/60Oqq7U8bsN0jsgi8Blpzr8WFvgX5s/TvRDIGMjoVk9dBj8YXmBUBZcRtdL4fGmDOrDaIb5j1f4ihqLATj/ieGys5zVqgnU+eswA/XQDb8k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700723477; bh=V/OALe/+QNK8qQbB8ii86gqUYRKt5b0ZND9ITXxgTJ4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UtOhQJdoyvXDmPogYHHFI/z6gnR07EtdYlflZr2L6r9aC/JULlg6l6WtArfFlOp8r LdZVe5XX9PphZzGky1mEtH6GbNgWJTr36aT6MXO0s9PLJwq65bXlN4hjJMv1lAgyLs Uwm3HcjXj1yHG0/IgLTNutKaOZlqBoUqz7BXaMr8= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id CEC7A66B3A; Thu, 23 Nov 2023 02:11:16 -0500 (EST) Message-ID: <2d1c9d59544d15ef7fba07d758431da840cc0bfe.camel@xry111.site> Subject: Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578] From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Thu, 23 Nov 2023 15:11:14 +0800 In-Reply-To: References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-2-xry111@xry111.site> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-11-23 at 14:35 +0800, chenglulu wrote: > Hi, >=20 > =C2=A0=C2=A0I don=E2=80=99t quite understand this part. Is it because def= ine_insn would be=20 > duplicated with the above implementation, >=20 > so define_insn_and_split is used? Yes, but if you think duplicating the above implementation is better I can dup it as well (as it's just a single line). (I wrote it as a define_expand but it didn't work, then I modified it to define_insn_and_split). > > +(define_insn_and_split "fix_trunc2" > > +=C2=A0 [(set (match_operand: 0 "register_operand" "=3Df") > > + (fix: (match_operand:FVEC 1 "register_operand" "f")))] > > +=C2=A0 "" > > +=C2=A0 "#" > > +=C2=A0 "" > > +=C2=A0 [(const_int 0)] > > +=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 emit_insn (gen__vftintrz__ ( > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 operands[0], operands[1])); > > +=C2=A0=C2=A0=C2=A0 DONE; > > +=C2=A0 } > > +=C2=A0 [(set_attr "type" "simd_fcvt") > > +=C2=A0=C2=A0 (set_attr "mode" "")]) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University