* [PATCH] Fix check_GNU_style.sh for BSD / Mac OS X
@ 2016-06-03 15:41 Alan Hayward
2016-06-09 16:32 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Alan Hayward @ 2016-06-03 15:41 UTC (permalink / raw)
To: gcc-patches
check_GNU_style.sh fails to detect lines >80 chars on BSD / Mac OS X
systems.
This is becuase paste is being called with an empty delimiter list.
Instead \0 should be used.
Tested on Ubuntu 14.04 and OS X 10.9.5
contrib/
* check_GNU_style.sh: Fix paste args for BSD
Alan
diff --git a/contrib/check_GNU_style.sh b/contrib/check_GNU_style.sh
index
a7478f8f573132aef5ed1010f0cf5b13f08350d4..87a276c9cf47b5e07c4407f740ce05dce
1928c30 100755
--- a/contrib/check_GNU_style.sh
+++ b/contrib/check_GNU_style.sh
@@ -191,7 +191,7 @@ col (){
# Combine prefix back with long lines.
# Filter out empty lines.
local found=false
- paste -d '' "$tmp2" "$tmp3" \
+ paste -d '\0' "$tmp2" "$tmp3" \
| grep -v '^[0-9][0-9]*:+$' \
> "$tmp" && found=true
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix check_GNU_style.sh for BSD / Mac OS X
2016-06-03 15:41 [PATCH] Fix check_GNU_style.sh for BSD / Mac OS X Alan Hayward
@ 2016-06-09 16:32 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2016-06-09 16:32 UTC (permalink / raw)
To: Alan Hayward, gcc-patches
On 06/03/2016 09:41 AM, Alan Hayward wrote:
> check_GNU_style.sh fails to detect lines >80 chars on BSD / Mac OS X
> systems.
>
> This is becuase paste is being called with an empty delimiter list.
> Instead \0 should be used.
>
> Tested on Ubuntu 14.04 and OS X 10.9.5
>
> contrib/
> * check_GNU_style.sh: Fix paste args for BSD
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-09 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03 15:41 [PATCH] Fix check_GNU_style.sh for BSD / Mac OS X Alan Hayward
2016-06-09 16:32 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).