From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101837 invoked by alias); 23 Nov 2017 14:30:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101742 invoked by uid 89); 23 Nov 2017 14:30:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 14:30:01 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D38BB883AB; Thu, 23 Nov 2017 14:29:59 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1757160634; Thu, 23 Nov 2017 14:29:58 +0000 (UTC) Subject: Re: [RFA][PATCH] Use SCEV conditionally within vr-values and evrp range analysis To: Richard Biener Cc: gcc-patches References: <80038401-a229-aba2-712d-1082aaa39b65@redhat.com> From: Jeff Law Message-ID: <2d549a96-e577-37ea-3c8d-526306bca941@redhat.com> Date: Thu, 23 Nov 2017 15:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02138.txt.bz2 On 11/23/2017 05:49 AM, Richard Biener wrote: > On Thu, Nov 23, 2017 at 1:16 AM, Jeff Law wrote: >> >> Clients of the evrp range analysis may not have initialized the SCEV >> infrastructure, and in fact my not want to (DOM for example). >> >> Yet inside both vr-values.c and gimple-ssa-evrp-analyze.c we have calls >> into SCEV (that will fault/abort if SCEV is not properly initialized). >> >> This patch allows clients of vr-values.c and gimple-ssa-evrp-analyze.c >> to indicate if they want SCEV analysis. >> >> Bootstrapped and regression tested by itself as well as with the DOM >> patches to use EVRP analysis (which test the "don't want SCEV path). >> >> OK for the trunk? > > There's also scev_initialized_p () which you could conveniently use. Wasn't aware of it. That's almost certainly a better solution. Jeff