From: Jeff Law <jeffreyalaw@gmail.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: macro@embecosm.com, Vineet Gupta <vineetg@rivosinc.com>,
gcc-patches@gcc.gnu.org, Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Kito Cheng <kito.cheng@gmail.com>,
Patrick O'Neill <patrick@rivosinc.com>,
gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing <gnu/stubs-ilp32d.h>
Date: Wed, 27 Sep 2023 16:04:41 -0600 [thread overview]
Message-ID: <2d6fbe06-1d70-40d2-aa6b-fff52b7acc94@gmail.com> (raw)
In-Reply-To: <mhng-4c772870-4f59-4e6d-bec8-0eecf64a8ba9@palmer-ri-x1c9>
On 9/27/23 11:32, Palmer Dabbelt wrote:
>
> IMO this is one of those places where we should just be as normal as
> possible. So if the other big ports allow system headers then we
> should, otherwise we should move everyone over to testing in some way
> we'll catch these before commit.
Exactly. I think the dance we've been doing with stdint-gcc.h is a bit
silly, but I haven't pushed on it at all.
No other port does anything similar. When they need stdint.h, they
include it. It does mean you have to have the appropriate headers
installed for each multilib configuration, but that's the way every
other port handles this problem. There's no good reason I'm aware of
for RISC-V to be different.
jeff
next prev parent reply other threads:[~2023-09-27 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 23:18 Maciej W. Rozycki
2023-09-23 5:48 ` Jeff Law
2023-09-26 9:22 ` Maciej W. Rozycki
2023-09-24 7:12 ` Vineet Gupta
2023-09-25 20:48 ` Maciej W. Rozycki
2023-09-25 21:17 ` Maciej W. Rozycki
2023-09-27 17:28 ` Jeff Law
2023-09-27 17:32 ` Palmer Dabbelt
2023-09-27 22:04 ` Jeff Law [this message]
2023-09-28 9:46 ` Maciej W. Rozycki
2023-09-29 21:03 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d6fbe06-1d70-40d2-aa6b-fff52b7acc94@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=macro@embecosm.com \
--cc=palmer@dabbelt.com \
--cc=patrick@rivosinc.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).