From: Robin Dapp <rdapp.gcc@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@dabbelt.com>, "kito.cheng" <kito.cheng@gmail.com>,
"Jeff Law" <jeffreyalaw@gmail.com>
Cc: rdapp.gcc@gmail.com
Subject: Re: [PATCH] RISC-V: Implement vec_set and vec_extract.
Date: Mon, 12 Jun 2023 17:26:59 +0200 [thread overview]
Message-ID: <2d770ff1-c853-9d87-bcbb-4454f01f08ed@gmail.com> (raw)
In-Reply-To: <5B32D472E11EDCC1+202306122313083169202@rivai.ai>
> + /* If the slide offset fits into 5 bits we can
> + use the immediate variant instead of the register variant.
> + The expander's operand[2] is ops[3] here. */
> + if (!satisfies_constraint_K (ops[3]))
> + ops[3] = force_reg (Pmode, ops[3]);
>
> I don't think we need this. maybe_expand_insn should be able to handle this.
Yes, removed it locally and retested, clean.
Regards
Robin
next prev parent reply other threads:[~2023-06-12 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:55 Robin Dapp
2023-06-12 15:13 ` 钟居哲
2023-06-12 15:26 ` Robin Dapp [this message]
2023-06-12 19:16 ` Jeff Law
2023-06-13 6:49 ` juzhe.zhong
2023-06-13 6:50 ` Robin Dapp
2023-06-13 14:10 ` Jeff Law
2023-06-16 13:41 ` [PATCH v2] " Robin Dapp
2023-06-16 13:55 ` 钟居哲
2023-06-17 2:12 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d770ff1-c853-9d87-bcbb-4454f01f08ed@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).