From: Jeff Law <law@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Yvan Roux <yvan.roux@linaro.org>, Bruce Korb <bkorb@gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>,
Jakub Jelinek <jakub@redhat.com>,
Matthew Fortune <matthew.fortune@imgtec.com>
Subject: Re: [PATCH] Fix fixincludes for canadian cross builds - next try
Date: Fri, 28 Apr 2017 19:13:00 -0000 [thread overview]
Message-ID: <2d83a6cb-1bef-f16c-15ef-7bd14b71c238@redhat.com> (raw)
In-Reply-To: <AM4PR0701MB2162A17EC17A871EDFDA4CD9E41B0@AM4PR0701MB2162.eurprd07.prod.outlook.com>
On 04/20/2017 01:11 PM, Bernd Edlinger wrote:
> Hi!
>
> This is my new attempt to clean up the different cross compiler
> configurations. It turned out to be a very complicated matter,
> so I thought it would be better to postpone it to the stage1.
>
> In a canadian cross compiler setup we have a different header dir path
> for use in the build and later on the target, which is written to
> install-tools/mkheaders.conf, so I propose to export SYSTEM_HEADER_DIR
> and BUILD_SYSTEM_HEADER_DIR from configure.ac to be used in Makefile.in.
>
> I also removed unnecessary handling of --with-headers, because
> the headers are copied to sys-include and thus it is not necessary to
> use the original path here.
>
> If --with-sysroot or --with-build-sysroot is used the SYSTEM_HEADER_DIR
> or BUILD_SYSTEM_HEADER_DIR contain $${sysroot_headers_suffix},
> which is normally an empty string, but on mips it may be something
> like "mips-r2" which gets appended to the sysroot for use of fixincludes
> but "target_header_dir" which is used in configure to find things like
> the GLIBC version it is not used. I assume that that either does
> not create problems and is silently ignored, or that people have a
> work around, my patch should not change that, however I have not been
> able to setup a sysroot for mips*-img-linux* or mips*-mti-linux* which
> seem to be the only targets where this might make a difference.
>
> I have tested all different combinations of --with-sysroot /
> --with-build-sysroot. Even a native build with --with-sysroot works.
> Except go of course: cross-builds are a no-go area for the go language
> in general;)
>
> As before I would appreciate your kind help with testing the many
> different build setups.
>
>
> So far I have tested native x86_64-pc-linux-gnu and arm-linux-gnueabihf
> cross build configurations. And everything looks sane.
>
> Is it OK for trunk?
>
>
> Thanks
> Bernd.
>
>
> fixinc.diff
>
>
> 2017-04-18 Bernd Edlinger<bernd.edlinger@hotmail.de>
>
> * configure.ac (SYSTEM_HEADER_DIR, BUILD_SYSTEM_HEADER_DIR,
> target_header_dir): Set correctly.
> * configure: Regenerated.
> * Makefile.in (BUILD_SYSTEM_HEADER_DIR): New make variabe.
> (LIMITS_H_TEST, if_multiarch, stmp-fixinc): Use BUILD_SYSTEM_HEADER_DIR
> instead of SYSTEM_HEADER_DIR.
OK. Please watch for fallout. I'm not entirely sure mingw is working
right now, but they're often affected by this stuff.
jeff
prev parent reply other threads:[~2017-04-28 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 18:44 [PATCH] Fix fixincludes for canadian cross builds Bernd Edlinger
2017-02-18 1:07 ` Bruce Korb
2017-02-18 11:39 ` Bernd Edlinger
2017-02-20 18:18 ` Bruce Korb
2017-04-12 15:59 ` Yvan Roux
2017-04-12 16:22 ` Bruce Korb
2017-04-14 4:18 ` Bernd Edlinger
2017-04-14 8:24 ` Yvan Roux
2017-04-14 10:37 ` Bernd Edlinger
2017-04-14 11:20 ` Yvan Roux
2017-04-18 18:29 ` Bernd Edlinger
2017-04-19 7:56 ` Yvan Roux
2017-04-20 20:29 ` [PATCH] Fix fixincludes for canadian cross builds - next try Bernd Edlinger
2017-04-20 20:35 ` Matthew Fortune
2017-04-21 10:41 ` Yvan Roux
2017-04-28 19:13 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d83a6cb-1bef-f16c-15ef-7bd14b71c238@redhat.com \
--to=law@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=bkorb@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=matthew.fortune@imgtec.com \
--cc=rguenther@suse.de \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).