From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9E0843858D20 for ; Thu, 7 Sep 2023 19:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E0843858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694114335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2EDticCUnpZ8hBupZ5ww/A9ZOscebBdiVhpWen8sE3Y=; b=Zj/Zsh4WsO326GPut3koleATVkIEvzi0bm8/AEgl+oucjk6ll9HIJqS9KeA2j+9+Bq0wdp mREgJGOsqlmCbGv/RDcUP5Rp77qiCbgKwt0PzVnYzDT5Hcn48xTP6dmYj38iV3wE4of9oZ lgnSYBYb0NqHVo6uPmcsvVhUVvnZ8vo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-JeDWOBLxP5-Otc7E6ZKG1w-1; Thu, 07 Sep 2023 15:18:53 -0400 X-MC-Unique: JeDWOBLxP5-Otc7E6ZKG1w-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-76da22d28f0so140854085a.1 for ; Thu, 07 Sep 2023 12:18:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694114333; x=1694719133; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2EDticCUnpZ8hBupZ5ww/A9ZOscebBdiVhpWen8sE3Y=; b=TaGhJWaAU6LKL9tq9surYVWHKOfjjh9tUoub0YlkDFOSF+cfa4SGV3KjtEcN0gz2uU sDYi2jn9KRgCqDPSF2wJHRq5YrT6lwtd3v51c7lIHReEgDy7xwGr0Zx6r6yFJZ6EVbIe SYOfletyMdgU1gi9NKoer6w9VQOpsKprduUyz//i7VA5gZZapKaZxudIaj3qf9X2FnpR ALIZa8kCr1oAAI3T0x5BWYI7KSMuevSXW2KIVuutqgk+qSG3GW71Wdi3o09BCD3yZ91h 9o16tVb8HJKIwwZNtPfgoxw1w1TkdYOmU6pik5odoEMeRPn8FV8wYVCwQZt2Ny81/70M 61lA== X-Gm-Message-State: AOJu0YyLwg/ztWlhuVHZsppMOblcuvgZxBdyaznXhk2Y1SRQmfBg+Wy6 3pBQl4zO6y1LREwBlen4CMyxqxNZr6Xl7peyLAqTQ4jM6Nary8HjJS5IXkXFbmJjws1Wya42Xtm BSTP7ohsf3555Moc5QQ== X-Received: by 2002:a05:620a:24d1:b0:768:13b6:e9e7 with SMTP id m17-20020a05620a24d100b0076813b6e9e7mr478304qkn.63.1694114333391; Thu, 07 Sep 2023 12:18:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoytuyAdWRA2GPmKnLFeRrzkDrjL0NL3E3FraZBsyeZb9mViROPvhVcP1/bqloNzaChhi51Q== X-Received: by 2002:a05:620a:24d1:b0:768:13b6:e9e7 with SMTP id m17-20020a05620a24d100b0076813b6e9e7mr478293qkn.63.1694114333139; Thu, 07 Sep 2023 12:18:53 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id oo21-20020a05620a531500b00767d47eb29bsm5974353qkn.119.2023.09.07.12.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 12:18:52 -0700 (PDT) Message-ID: <2d857252-98b7-733c-f0aa-348a7d39eb4d@redhat.com> Date: Thu, 7 Sep 2023 15:18:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] c++: cache conversion function lookup To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20230906220737.4049357-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20230906220737.4049357-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/6/23 18:07, Patrick Palka wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for > trunk? This cache apparently has a 98% hit rate for TYPE_HAS_CONVERSION > types on some test files. Does it make a measurable difference in compile time? > +/* A cache of the result of lookup_conversions. */ > + > +static GTY((cache)) type_tree_cache_map *lookup_conversions_cache; This should probably be (deletable) rather than (cache)? Jason