* [GCC 11] [COMMITTED] Disable poor value processing in ranger cache.
@ 2021-07-14 22:08 Andrew MacLeod
0 siblings, 0 replies; only message in thread
From: Andrew MacLeod @ 2021-07-14 22:08 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
We have disabled the poor value cache in trunk as not providing enough
benefit for the cost. do the same in gcc 11.
Bootstrapped on x86_64-pc-linux-gnu with no regressions. pushed.
Andrew
[-- Attachment #2: 0005-Disable-poor-value-processing-in-ranger-cache.patch --]
[-- Type: text/x-patch, Size: 1452 bytes --]
From 86534c07a390e240ffea51653945de85df7a3632 Mon Sep 17 00:00:00 2001
From: Andrew MacLeod <amacleod@redhat.com>
Date: Wed, 23 Jun 2021 12:55:14 -0400
Subject: [PATCH 5/8] Disable poor value processing in ranger cache.
* gimple-range-cache.cc (ranger_cache::push_poor_value): Disable
poor value processing.
---
gcc/gimple-range-cache.cc | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index bc4b557b493..068905d4774 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -846,20 +846,9 @@ ranger_cache::register_dependency (tree name, tree dep)
bool
ranger_cache::push_poor_value (basic_block bb, tree name)
{
- if (m_poor_value_list.length ())
- {
- // Don't push anything else to the same block. If there are multiple
- // things required, another request will come during a later evaluation
- // and this prevents oscillation building uneccessary depth.
- if ((m_poor_value_list.last ()).bb == bb)
- return false;
- }
-
- struct update_record rec;
- rec.bb = bb;
- rec.calc = name;
- m_poor_value_list.safe_push (rec);
- return true;
+ // Disable poor value processing for GCC 11. It has been disabled in GCC 12
+ // as adding too much churn/compile time for too little benefit.
+ return false;
}
// Provide lookup for the gori-computes class to access the best known range
--
2.17.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-14 22:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 22:08 [GCC 11] [COMMITTED] Disable poor value processing in ranger cache Andrew MacLeod
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).