From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1BDB73858D35 for ; Fri, 24 Mar 2023 15:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BDB73858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679670545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=ht6aOs3CtgrOxMXarOMHOcjVPv7WSO8g5iXK4fli5hM=; b=hE9b3d8Lm4nPPRhiENbeN9yFosDXSf3NRis3+ODnRbQ7vSntXiWAAwcCE6BQT1po1/vM/r r6ExDudGfg9eruANJPBXFteXPfKKNKGQBdM2so00MxmxQjj0OkdtqpIiiuLK03nZHlb3xH UbMuJHW2UZ9BVEu9mI27nJG2vR+QkBQ= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-31-rRe88-4RPUKA0d1nKBl_JQ-1; Fri, 24 Mar 2023 11:09:02 -0400 X-MC-Unique: rRe88-4RPUKA0d1nKBl_JQ-1 Received: by mail-qt1-f200.google.com with SMTP id h6-20020a05622a170600b003e22c6de617so1201235qtk.13 for ; Fri, 24 Mar 2023 08:09:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679670541; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P7Nn0TPAfXt5/P64r6h6UHm0rsKBZPUVK3V9AjY8tj4=; b=iRoNd4GHjjbxQ2pc2k3fm+nTlF2B101BLKsgu3u8koZzpgMdeZqlT7o9y/MhaGTMLh E/0V/ZkcDjXZQ8cYVj75JWqL6CwfxnqYfCBAMqSwXo6VrweuuEC3kpPzzDcy3TlWNIaa TxSZlsMuNXjx6E9ReJI9zZUZGmLOzyN9Ldu0mx0IS6OE3E7fthl6TpXR1Qc/f04GVMrx oUMbueZMayDegLkF47W707ZVHuDQLFg4kWuCLSm+VzkmsGiSJQphfMaAk/lAT0tjcikR jZxwNQNuWdQgRmm6kNHcR+rZXaiI2dzx+v9tuGxrEKYjQWEZGkJjYlHSbgptYPugLalJ CDeA== X-Gm-Message-State: AAQBX9dWC4I8aqZhJ7hENN1QuMwNW/jzN77JiEwZQlwLjcCoApJtHrbe PWDzQl56xmtLcgCvI9eGLdbg2ZRJcOPN+OTZy1+/+nNCkfkyfgevsmgL7rPhjThsgnPl2egCOzl 0zfwtn05OGA8ppxhnCuvO61UBZSApqAftDGzckftywnWxdBZhX6TVgfU0m3Db6+Ng35b7d/nzQD +AYA== X-Received: by 2002:a05:6214:1bcb:b0:5ab:8087:91f2 with SMTP id m11-20020a0562141bcb00b005ab808791f2mr5396203qvc.7.1679670541329; Fri, 24 Mar 2023 08:09:01 -0700 (PDT) X-Google-Smtp-Source: AKy350YzGGLJh0u++qouUFsI2FLFC1DLEwcmH633UIIGIECUibYtysry/GcXoR6PJMpyYS6XrEswug== X-Received: by 2002:a05:6214:1bcb:b0:5ab:8087:91f2 with SMTP id m11-20020a0562141bcb00b005ab808791f2mr5395518qvc.7.1679670536090; Fri, 24 Mar 2023 08:08:56 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::759b? ([2607:fea8:a263:f600::759b]) by smtp.gmail.com with ESMTPSA id bl28-20020a05620a1a9c00b007339c5114a9sm14388624qkb.103.2023.03.24.08.08.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 08:08:55 -0700 (PDT) Message-ID: <2e0b9177-f8ce-d55a-d6bb-71eb89a9700d@redhat.com> Date: Fri, 24 Mar 2023 11:08:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: gcc-patches , Jakub Jelinek , Richard Biener From: Andrew MacLeod Subject: [PATCH] PR tree-optimization/109274 - Don't interpret contents of a value_relation record. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------lnRbwI0mIeEcOPMBV69jRRfE" Content-Language: en-US X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------lnRbwI0mIeEcOPMBV69jRRfE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Before floating point relations were added, we tried to sanitize value-relation records to not include non-sensensical records... ie x != x or x < x.   Instead, we made a VREL_VARYING record with no operands. When floating point relation support was added, some of these were no longer non-sensical, AND we expanded the use of value_relation records into GORI shortly thereafter. As a result, this sanitization is no longer needed, nor desired. The Oracle does not create records with op1 == op2 already, so its only within GORI that these records can exist, and we shouldn't try to interpret them. The bug occurs because the "sanitized" records doesn't set op1 and op2, and changes the relation to VARYING..  and we expected the operands it to be set the way they were specified.  We should not be setting a VREL_VARYING record if asked to set something else.  In fact, we are missing some opportunities because we are trying to FP range-ops that op1 != op1  but its getting transformed into a VREL_VARYING record and not communicated properly. Currently bootstrapping on x86_64-pc-linux-gnu and assuming no regressions, OK for trunk? Andrew --------------lnRbwI0mIeEcOPMBV69jRRfE Content-Type: text/x-patch; charset=UTF-8; name="274.diff" Content-Disposition: attachment; filename="274.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDFmMDI5NjFiMjM5NzZkMzViMTBlMjM5OTcwOGM2ZWIwMDYzMmY5ZDYKQXV0aG9yOiBB bmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgTWFyIDI0IDA5 OjE4OjMzIDIwMjMgLTA0MDAKCiAgICBEb24ndCBpbnRlcnByZXQgY29udGVudHMgb2YgYSB2YWx1 ZV9yZWxhdGlvbiByZWNvcmQuCiAgICAKICAgIGJlZm9yZSBmbG9hdGluZyBwb2ludCByZWxhdGlv bnMgd2VyZSBhZGRlZCwgd2UgdHJpZWQgdG8gc2FuaXRpemUKICAgIHZhbHVlLXJlbGF0aW9uIHJl Y29yZHMgdG8gbm90IGluY2x1ZGUgbm9uLXNlbnNlbnNpY2FsIHJlY29yZHMuLi4gaWUKICAgIHgg IT0geCBvciB4IDwgeC4gICBJTnN0ZWFkLCB3ZSBtYWRlIGEgVlJFTF9WQVJZSU5HIHJlY29yZCB3 aXRoIG5vCiAgICBvcGVyYW5kcy4KICAgIAogICAgV2hlbiBmbG9hdGluZyBwb2ludCByZWxhdGlv bnMgd2VyZSBzdXBwb3J0ZWQsIHNvbWUgb2YgdGhlc2Ugd2VyZSBubwogICAgbG9uZ2VyIG5vbi1z ZW5zaWNhbCwgQU5EIHdlIGV4cGFuZGVkIHRoZSB1c2Ugb2YgdmFsdWVfcmVsYXRpb24gcmVjb3Jk cwogICAgaW50byBHT1JJLgogICAgCiAgICBBcyBhIHJlc3VsdCwgdGhpcyBzYW5pdGl6YXRpb24g aXMgbm8gbG9uZ2VyIG5lZWRlZC4gIFRoZSBPcmFjbGUKICAgIGRvZXMgbm90IGNyZWF0ZSByZWNv cmRzIHdpdGggb3AxID09IG9wMiwgc28gaXRzIG9ubHkgd2l0aGluIEdPUkkKICAgIHRoYXQgdGhl c2UgcmVjb3JkcyBjYW4gZXhpc3QsIGFuZCB3ZSBzaG91bGRudCB0cnkgdG8gaW50ZXJwcmV0IHRo ZW0uCiAgICAKICAgIFRoZSBidWcgb2NjdXJzIGJlY2F1c2UgdGhlICJzYW5pdGl6ZWQiIHJlY29y ZHMgZG9lc250IHNldCBvcDEgYW5tZCBvcDIsCiAgICBidXQgd2UgaGF2ZSBhIHJlY29yZCBzbyBl eHBlY3RlZCBpdCB0byBiZSBzZXQuCiAgICAKICAgICAgICAgICAgUFIgdHJlZS1vcHRpbWl6YXRp b24vMTA5MjY1CiAgICAgICAgICAgIFBSIHRyZWUtb3B0aW1pemF0aW9uLzEwOTI3NAogICAgICAg ICAgICBnY2MvCiAgICAgICAgICAgICogdmFsdWUtcmVsYXRpb24uaCAodmFsdWVfcmVsYXRpb246 OnNldF9yZWxhdGlvbik6IEFsd2F5cyBjcmVhdGUgdGhlCiAgICAgICAgICAgIHJlY29yZCB0aGF0 IGlzIHJlcXVlc3RlZC4KICAgIAogICAgICAgICAgICBnY2MvdGVzdHN1aXRlLwogICAgICAgICAg ICAqIGdjYy5kZy9wcjEwOTI3NC5jOiBOZXcuCgpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9n Y2MuZGcvcHIxMDkyNzQuYyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMTA5Mjc0LmMKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjVkYmMwMjMyZjhlCi0tLSAvZGV2L251 bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIxMDkyNzQuYwpAQCAtMCwwICsxLDE2IEBA CisvKiBQUiB0cmVlLW9wdGltaXphdGlvbi8xMDkyNzQgKi8KKy8qIHsgZGctZG8gY29tcGlsZSB9 ICovCisvKiB7IGRnLW9wdGlvbnMgIi1PMiAiIH0gKi8KKworZmxvYXQgYSwgYiwgYzsKK2ludCBk OworZmxvYXQgYmFyICh2b2lkKTsKKwordm9pZAorZm9vICh2b2lkKQoreworICBhID0gMCAqIC0o Mi4wZiAqIGMpOworICBkID0gYSAhPSBhID8gMCA6IGJhciAoKTsKKyAgYiA9IGM7Cit9CisKZGlm ZiAtLWdpdCBhL2djYy92YWx1ZS1yZWxhdGlvbi5oIGIvZ2NjL3ZhbHVlLXJlbGF0aW9uLmgKaW5k ZXggMzZhNzU4NjJjYzcuLjMxNzdlY2IxYWQwIDEwMDY0NAotLS0gYS9nY2MvdmFsdWUtcmVsYXRp b24uaAorKysgYi9nY2MvdmFsdWUtcmVsYXRpb24uaApAQCAtNDQ1LDEzICs0NDUsNiBAQCB2YWx1 ZV9yZWxhdGlvbjo6c2V0X3JlbGF0aW9uIChyZWxhdGlvbl9raW5kIHIsIHRyZWUgbjEsIHRyZWUg bjIpCiB7CiAgIGdjY19jaGVja2luZ19hc3NlcnQgKFRSRUVfQ09ERSAobjEpID09IFNTQV9OQU1F CiAJCSAgICAgICAmJiBUUkVFX0NPREUgKG4yKSA9PSBTU0FfTkFNRSk7Ci0gIGlmIChuMSA9PSBu MiAmJiByICE9IFZSRUxfRVEpCi0gICAgewotICAgICAgcmVsYXRlZCA9IFZSRUxfVkFSWUlORzsK LSAgICAgIG5hbWUxID0gTlVMTF9UUkVFOwotICAgICAgbmFtZTIgPSBOVUxMX1RSRUU7Ci0gICAg ICByZXR1cm47Ci0gICAgfQogICByZWxhdGVkID0gcjsKICAgbmFtZTEgPSBuMTsKICAgbmFtZTIg PSBuMjsK --------------lnRbwI0mIeEcOPMBV69jRRfE--