From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12733 invoked by alias); 13 Feb 2014 22:10:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12724 invoked by uid 89); 13 Feb 2014 22:10:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 13 Feb 2014 22:10:27 +0000 From: "Steve Ellcey " Date: Thu, 13 Feb 2014 22:10:00 -0000 To: Subject: [PATCH, testsuite] Fix profile test failures User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <2e4e3d80-6505-4f09-8a24-01e99dcda418@BAMAIL02.ba.imgtec.org> X-SEF-Processed: 7_3_0_01192__2014_02_13_22_10_24 X-SW-Source: 2014-02/txt/msg00862.txt.bz2 While testing the C++ profiling tests in g++.dg/bprob and using the qemu simulator we discovered that these tests were passing when we ran the testsuite with no extra options but that if we specified some options on the testsuite run then the tests would fail with this message in the c++.log file: rsh: Could not resolve hostname multi-sim/-EL: Name or service not known After some poking around I found that profopt-execute in lib/profopt.exp was using remote_file and remote_upload with 'target' where I believe it should be using 'host'. No other *.exp file uses 'target' on their remote_file or remote_update calls, they either use 'build' or 'host'. So while it seems weird that 'host' is the proper replacement for 'target' as the machine where the executable is run, this seems to be the right fix and it does give me a clean run now with or without extra arguments on the test run. OK for checkin? Steve Ellcey sellcey@mips.com 2014-02-13 Steve Ellcey * lib/profopt.exp (profopt-execute): Use host instead of target in remote_file and remote_upload calls. diff --git a/gcc/testsuite/lib/profopt.exp b/gcc/testsuite/lib/profopt.exp index e0d849e..e045b53 100644 --- a/gcc/testsuite/lib/profopt.exp +++ b/gcc/testsuite/lib/profopt.exp @@ -264,7 +264,7 @@ proc profopt-execute { src } { # Remove old profiling and performance data files. foreach ext $prof_ext { - remote_file target delete $tmpdir/$base.$ext + remote_file host delete $tmpdir/$base.$ext } if [info exists perf_ext] { profopt-cleanup $testcase $perf_ext @@ -312,7 +312,7 @@ proc profopt-execute { src } { # Make sure the profile data was generated, and fail if not. if { $status == "pass" } { foreach ext $prof_ext { - remote_upload target $tmpdir/$base.$ext + remote_upload host $tmpdir/$base.$ext set files [glob -nocomplain $base.$ext] if { $files == "" } { set status "fail" @@ -368,7 +368,7 @@ proc profopt-execute { src } { # Remove the profiling data files. foreach ext $prof_ext { - remote_file target delete $tmpdir/$base.$ext + remote_file host delete $tmpdir/$base.$ext } if { $status != "pass" } {