From: Christophe LYON <christophe.lyon@foss.st.com>
To: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 00/13] ARM/MVE use vectors of boolean for predicates
Date: Mon, 13 Sep 2021 10:33:02 +0200 [thread overview]
Message-ID: <2e64a0fc-ed92-47f0-7adc-7d93b787cd32@foss.st.com> (raw)
In-Reply-To: <20210907091531.1034282-1-christophe.lyon@foss.st.com>
ping?
On 07/09/2021 11:15, Christophe Lyon wrote:
> This patch series addresses PR 100757 and 101325 by representing
> vectors of predicates (MVE VPR.P0 register) as vectors of booleans
> rather than using HImode.
>
> As this implies a lot of mostly mechanical changes, I have tried to
> split the patches in a way that should help reviewers, but the split
> is a bit artificial.
>
> Patches 1-3 add new tests.
>
> Patches 4-6 are small independent improvements.
>
> Patch 7 implements the predicate qualifier, but does not change any
> builtin yet.
>
> Patch 8 is the first of the two main patches, and uses the new
> qualifier to describe the vcmp and vpsel builtins that are useful for
> auto-vectorization of comparisons.
>
> Patch 9 is the second main patch, which fixes the vcond_mask expander.
>
> Patches 10-13 convert almost all the remaining builtins with HI
> operands to use the predicate qualifier. After these, there are still
> a few builtins with HI operands left, about which I am not sure: vctp,
> vpnot, load-gather and store-scatter with v2di operands. In fact,
> patches 11/12 update some STR/LDR qualifiers in a way that breaks
> these v2di builtins although existing tests still pass.
>
> Christophe Lyon (13):
> arm: Add new tests for comparison vectorization with Neon and MVE
> arm: Add tests for PR target/100757
> arm: Add test for PR target/101325
> arm: Add GENERAL_AND_VPR_REGS regclass
> arm: Add support for VPR_REG in arm_class_likely_spilled_p
> arm: Fix mve_vmvnq_n_<supf><mode> argument mode
> arm: Implement MVE predicates as vectors of booleans
> arm: Implement auto-vectorized MVE comparisons with vectors of boolean
> predicates
> arm: Fix vcond_mask expander for MVE (PR target/100757)
> arm: Convert remaining MVE vcmp builtins to predicate qualifiers
> arm: Convert more MVE builtins to predicate qualifiers
> arm: Convert more load/store MVE builtins to predicate qualifiers
> arm: Convert more MVE/CDE builtins to predicate qualifiers
>
> gcc/config/arm/arm-builtins.c | 228 +++--
> gcc/config/arm/arm-modes.def | 5 +
> gcc/config/arm/arm-protos.h | 3 +-
> gcc/config/arm/arm-simd-builtin-types.def | 4 +
> gcc/config/arm/arm.c | 128 ++-
> gcc/config/arm/arm.h | 5 +-
> gcc/config/arm/arm_mve_builtins.def | 746 ++++++++--------
> gcc/config/arm/iterators.md | 5 +
> gcc/config/arm/mve.md | 823 ++++++++++--------
> gcc/config/arm/neon.md | 39 +
> gcc/config/arm/vec-common.md | 52 --
> gcc/simplify-rtx.c | 7 +
> .../arm/acle/cde-mve-full-assembly.c | 264 +++---
> .../gcc.target/arm/simd/mve-vcmp-f32-2.c | 32 +
> .../gcc.target/arm/simd/neon-compare-1.c | 78 ++
> .../gcc.target/arm/simd/neon-compare-2.c | 13 +
> .../gcc.target/arm/simd/neon-compare-3.c | 14 +
> .../arm/simd/neon-compare-scalar-1.c | 57 ++
> .../gcc.target/arm/simd/neon-vcmp-f16.c | 12 +
> .../gcc.target/arm/simd/neon-vcmp-f32-2.c | 15 +
> .../gcc.target/arm/simd/neon-vcmp-f32-3.c | 12 +
> .../gcc.target/arm/simd/neon-vcmp-f32.c | 12 +
> gcc/testsuite/gcc.target/arm/simd/neon-vcmp.c | 22 +
> .../gcc.target/arm/simd/pr100757-2.c | 20 +
> .../gcc.target/arm/simd/pr100757-3.c | 20 +
> .../gcc.target/arm/simd/pr100757-4.c | 19 +
> gcc/testsuite/gcc.target/arm/simd/pr100757.c | 19 +
> gcc/testsuite/gcc.target/arm/simd/pr101325.c | 14 +
> 28 files changed, 1581 insertions(+), 1087 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/mve-vcmp-f32-2.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-2.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-3.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-compare-scalar-1.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f16.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32-2.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32-3.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp-f32.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/neon-vcmp.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-2.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-3.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757-4.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr100757.c
> create mode 100644 gcc/testsuite/gcc.target/arm/simd/pr101325.c
>
next prev parent reply other threads:[~2021-09-13 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:15 Christophe Lyon
2021-09-07 9:15 ` [PATCH 01/13] arm: Add new tests for comparison vectorization with Neon and MVE Christophe Lyon
2021-09-28 11:11 ` Kyrylo Tkachov
2021-09-07 9:15 ` [PATCH 02/13] arm: Add tests for PR target/100757 Christophe Lyon
2021-09-28 11:12 ` Kyrylo Tkachov
2021-09-28 13:28 ` Christophe LYON
2021-09-07 9:15 ` [PATCH 03/13] arm: Add test for PR target/101325 Christophe Lyon
2021-09-28 11:14 ` Kyrylo Tkachov
2021-09-28 13:30 ` Christophe LYON
2021-10-11 12:43 ` Christophe LYON
2021-09-07 9:15 ` [PATCH 04/13] arm: Add GENERAL_AND_VPR_REGS regclass Christophe Lyon
2021-09-07 9:42 ` Richard Earnshaw
2021-09-07 12:05 ` Christophe LYON
2021-09-07 13:35 ` Richard Earnshaw
2021-09-08 7:48 ` Christophe LYON
2021-09-28 11:18 ` Kyrylo Tkachov
2021-09-28 13:32 ` Christophe LYON
2021-10-11 12:44 ` Christophe LYON
2021-09-13 8:33 ` Christophe LYON [this message]
2021-09-20 9:21 ` [PATCH 00/13] ARM/MVE use vectors of boolean for predicates Christophe LYON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e64a0fc-ed92-47f0-7adc-7d93b787cd32@foss.st.com \
--to=christophe.lyon@foss.st.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).