From: Chris Demetriou <cgd@google.com>
To: gcc-patches@gcc.gnu.org
Subject: [obvious patch] add missing chmod to when copying headers
Date: Thu, 11 Mar 2010 20:31:00 -0000 [thread overview]
Message-ID: <2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
odd corner case when making/installing: if sources were checked out
with umask that denies group or other read (e.g. 077 or 027), most of
the installed gcc includes would come out group/other-readable but a
few wouldn't.
problem: missing chmods after copying the headers, in stmp-int-headers.
Since all of the rest of the headers are chmodded after copy, the
solution is obvious.
bootstrapped, verified permissions manually, committed as obvious.
chris
---
[gcc/ChangeLog]
2010-03-11 Chris Demetriou <cgd@google.com>
* Makefile.in (stmp-int-hdrs): Make include/unwind.h,
include/stdint-gcc.h, and include/stdint.h world-readable.
[-- Attachment #2: chmod.patch --]
[-- Type: text/x-diff, Size: 1027 bytes --]
[gcc/ChangeLog]
2010-03-11 Chris Demetriou <cgd@google.com>
* Makefile.in (stmp-int-hdrs): Make include/unwind.h,
include/stdint-gcc.h, and include/stdint.h world-readable.
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in (revision 157391)
+++ gcc/Makefile.in (working copy)
@@ -3835,14 +3835,17 @@
done
rm -f include/unwind.h
cp $(UNWIND_H) include/unwind.h
+ chmod a+r include/unwind.h
rm -f include/stdint.h
if [ $(USE_GCC_STDINT) = wrap ]; then \
rm -f include/stdint-gcc.h; \
cp $(srcdir)/ginclude/stdint-gcc.h include/stdint-gcc.h; \
+ chmod a+r include/stdint-gcc.h; \
cp $(srcdir)/ginclude/stdint-wrap.h include/stdint.h; \
elif [ $(USE_GCC_STDINT) = provide ]; then \
cp $(srcdir)/ginclude/stdint-gcc.h include/stdint.h; \
fi
+ chmod a+r include/stdint.h
set -e; for ml in `cat fixinc_list`; do \
sysroot_headers_suffix=`echo $${ml} | sed -e 's/;.*$$//'`; \
multi_dir=`echo $${ml} | sed -e 's/^[^;]*;//'`; \
next reply other threads:[~2010-03-11 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 20:31 Chris Demetriou [this message]
2010-03-11 21:55 ` Basile Starynkevitch
[not found] ` <2e7be40c1003111408g5d8cba66r9605cf12a79bb22c@mail.gmail.com>
2010-03-11 22:14 ` Chris Demetriou
2010-03-12 10:44 ` Paolo Bonzini
2010-03-12 19:52 ` Chris Demetriou
2010-03-12 20:26 ` Paolo Bonzini
2010-03-15 7:49 ` Eric Botcazou
2010-03-15 8:06 ` Chris Demetriou
2010-03-15 8:57 ` Chris Demetriou
2010-03-15 9:09 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com \
--to=cgd@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).