Re: [obvious patch] add missing chmod to when copying headers

[Chris Demetriou <cgd@google.com>]

On Thu, Mar 11, 2010 at 13:28, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
>
> Chris Demetriou wrote:
>>
>> odd corner case when making/installing: if sources were checked out
>> with umask that denies group or other read (e.g. 077 or 027), most of
>> the installed gcc includes would come out group/other-readable but a
>> few wouldn't.
>
> Perhaps the same should be done for PLUGIN_HEADERS (if not done yet).

AFAICT they are installed using $(install_data), so get reasonable perms, e.g.:

/usr/bin/install -c -m 644 ../../trunk/gcc/coretypes.h
/g/users/cgd/proj/gcc-trunk/bld/../inst/lib/gcc/x86_64-linux/4.5.0/plugin/include/coretypes.h


FYI, IIRC there are a few files that get built/installed with the
umask of the person doing the build.  This is probably is a bug in the
build/install process (IMO at least), but is easily fixable by using a
'good' umask when building.  (the files whose permissions I fixed,
OTOH, came from umask at *checkout* time... somewhat confusing, and
the way the makefile installed the rest of the related headers was
obviously different so IMO there was an obvious fix to make.  I've not
looked into other issues, my *build* scripts set a good umask.  8-)



chris