From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7576 invoked by alias); 11 Mar 2010 22:11:32 -0000 Received: (qmail 7563 invoked by uid 22791); 11 Mar 2010 22:11:31 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Mar 2010 22:11:27 +0000 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id o2BMBOER013771 for ; Thu, 11 Mar 2010 22:11:24 GMT Received: from pwj3 (pwj3.prod.google.com [10.241.219.67]) by kpbe12.cbf.corp.google.com with ESMTP id o2BMB3ZY025463 for ; Thu, 11 Mar 2010 14:11:23 -0800 Received: by pwj3 with SMTP id 3so284169pwj.12 for ; Thu, 11 Mar 2010 14:11:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.15.9 with SMTP id s9mr2090644rvi.221.1268345472383; Thu, 11 Mar 2010 14:11:12 -0800 (PST) In-Reply-To: <2e7be40c1003111408g5d8cba66r9605cf12a79bb22c@mail.gmail.com> References: <2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com> <4B996075.9020905@starynkevitch.net> <2e7be40c1003111408g5d8cba66r9605cf12a79bb22c@mail.gmail.com> Date: Thu, 11 Mar 2010 22:14:00 -0000 Message-ID: <2e7be40c1003111411m42481ff6j89bbb5ef75ab6238@mail.gmail.com> Subject: Re: [obvious patch] add missing chmod to when copying headers From: Chris Demetriou To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-03/txt/msg00455.txt.bz2 On Thu, Mar 11, 2010 at 13:28, Basile Starynkevitch wrote: > > Chris Demetriou wrote: >> >> odd corner case when making/installing: if sources were checked out >> with umask that denies group or other read (e.g. 077 or 027), most of >> the installed gcc includes would come out group/other-readable but a >> few wouldn't. > > Perhaps the same should be done for PLUGIN_HEADERS (if not done yet). AFAICT they are installed using $(install_data), so get reasonable perms, e= .g.: /usr/bin/install -c -m 644 ../../trunk/gcc/coretypes.h /g/users/cgd/proj/gcc-trunk/bld/../inst/lib/gcc/x86_64-linux/4.5.0/plugin/i= nclude/coretypes.h FYI, IIRC there are a few files that get built/installed with the umask of the person doing the build.=A0 This is probably is a bug in the build/install process (IMO at least), but is easily fixable by using a 'good' umask when building.=A0 (the files whose permissions I fixed, OTOH, came from umask at *checkout* time... somewhat confusing, and the way the makefile installed the rest of the related headers was obviously different so IMO there was an obvious fix to make.=A0 I've not looked into other issues, my *build* scripts set a good umask.=A0 8-) chris