Re: [obvious patch] add missing chmod to when copying headers

[Chris Demetriou <cgd@google.com>]

On Fri, Mar 12, 2010 at 02:23, Paolo Bonzini <bonzini@gnu.org> wrote:
>> bootstrapped, verified permissions manually, committed as obvious.
>
> ... but why didn't you use $(INSTALL_DATA)? :-)

*chuckle*  there are actually reasons, believe it or not!  Just
because it's obvious doesn't mean I didn't think about it.  8-)

(a) because the rest of the code here doesn't, and

(b) this *isn't* actually *installing* anything!  it's populating an
include directory internal to the build process.  The actual header
installation happens thanks to the install-headers-* targets AFAICT
(which don't use INSTALL_DATA either 8-).  It's not obvious to me
(esp. in light of the way the rest of the code works) that
INSTALL_DATA is appropriate here.


Changing install-headers-* may be appropriate... but it seems obvious
that a bunch of work was put into its current implementation as-is
(three separate implementations!).  At *minimum* that would be
non-obvious, whereas making all the headers copied in stmp-int-hdrs be
chmodded consistently *is* obvious.  8-)



chris