From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4277 invoked by alias); 12 Mar 2010 18:51:11 -0000 Received: (qmail 4269 invoked by uid 22791); 12 Mar 2010 18:51:10 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Mar 2010 18:51:06 +0000 Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id o2CIp48J002862 for ; Fri, 12 Mar 2010 10:51:04 -0800 Received: from pvd12 (pvd12.prod.google.com [10.241.209.204]) by kpbe14.cbf.corp.google.com with ESMTP id o2CIp3pj004751 for ; Fri, 12 Mar 2010 10:51:03 -0800 Received: by pvd12 with SMTP id 12so640701pvd.21 for ; Fri, 12 Mar 2010 10:51:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.58.20 with SMTP id g20mr2815701rva.132.1268419862883; Fri, 12 Mar 2010 10:51:02 -0800 (PST) In-Reply-To: <4B9A1629.20900@gnu.org> References: <2e7be40c1003111231u30e5a84fxb23393dcc4fab84c@mail.gmail.com> <4B9A1629.20900@gnu.org> Date: Fri, 12 Mar 2010 19:52:00 -0000 Message-ID: <2e7be40c1003121051w6bb3c2f1v96b9e12fd77e134a@mail.gmail.com> Subject: Re: [obvious patch] add missing chmod to when copying headers From: Chris Demetriou To: Paolo Bonzini Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-03/txt/msg00495.txt.bz2 On Fri, Mar 12, 2010 at 02:23, Paolo Bonzini wrote: >> bootstrapped, verified permissions manually, committed as obvious. > > ... but why didn't you use $(INSTALL_DATA)? :-) *chuckle* there are actually reasons, believe it or not! Just because it's obvious doesn't mean I didn't think about it. 8-) (a) because the rest of the code here doesn't, and (b) this *isn't* actually *installing* anything! it's populating an include directory internal to the build process. The actual header installation happens thanks to the install-headers-* targets AFAICT (which don't use INSTALL_DATA either 8-). It's not obvious to me (esp. in light of the way the rest of the code works) that INSTALL_DATA is appropriate here. Changing install-headers-* may be appropriate... but it seems obvious that a bunch of work was put into its current implementation as-is (three separate implementations!). At *minimum* that would be non-obvious, whereas making all the headers copied in stmp-int-hdrs be chmodded consistently *is* obvious. 8-) chris