From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mliska@suse.cz>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by sourceware.org (Postfix) with ESMTPS id 0348F3857C5A
 for <gcc-patches@gcc.gnu.org>; Mon, 23 Nov 2020 14:49:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0348F3857C5A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=suse.cz
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
 by mx2.suse.de (Postfix) with ESMTP id E2616AC23;
 Mon, 23 Nov 2020 14:49:14 +0000 (UTC)
Subject: Re: [PATCH] gcov: Add __gcov_info_to_gdca()
To: Sebastian Huber <sebastian.huber@embedded-brains.de>,
 gcc-patches@gcc.gnu.org
References: <20201117095741.3143-1-sebastian.huber@embedded-brains.de>
 <4806f0f4-2fee-867e-87ad-6831aedd9be7@suse.cz>
 <1df244a2-8e31-5c2d-ea3f-98114c10b405@embedded-brains.de>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
Message-ID: <2e82011f-c21b-a167-1f86-01ae0464ceb0@suse.cz>
Date: Mon, 23 Nov 2020 15:49:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <1df244a2-8e31-5c2d-ea3f-98114c10b405@embedded-brains.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2020 14:49:17 -0000

On 11/23/20 3:35 PM, Sebastian Huber wrote:
> If I have to wait for next stage 1, I can also try to refactor write_one_data() after your patch which removes the buffering.

Yes, please build your patches on top of the file buffering removal.

> This would avoid some duplicated code, however, it would require some changes in existing code. Is it allowed to remove external (hidden?) symbols from libgcov?

Which functions do you mean?

Martin