From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id A6A1C3856DE8 for ; Tue, 25 Jul 2023 22:24:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6A1C3856DE8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PJIrep017717 for ; Tue, 25 Jul 2023 22:24:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=nk/u+QtZ1lvYZqSAgyQE47Vd/7BSWts4s/uS5sJvl0w=; b=rAFZX3vEDg2U3u8ro8daE3jEA7isFennx/FEinEx+Pr6buBZ/eY8ZdO974lJrG/AApHX 8GMw7fC0jhTLmFaivLydQlQSNWtVMVqNHoB84i8BqxIFkihRTFpO+evI181cskLf77v0 qiFUCDPs0T5JKzM3wvGZNfmrWzMJjdj1JRN6qbScehyi13zPqkk6/DHxOx0aXd6HSQoU bi4zGl9UauV+SWGRfJ8ieeteaUaoXhdrE91DM6RNFAcC8QvSXY+17lWSti3YpfXGQA6v XsSX08UAs7O2CjPE14gJ42BRTvJ3pEcdU5jMURRrMTsSgl/vsgRWTKJUjEb9b1Bu/AJW Sg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s061c69dj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 22:24:02 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36PLfWix022995 for ; Tue, 25 Jul 2023 22:24:01 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3s05j5d55y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 22:24:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVzRFnZsbb1O7ERs5RwJ7xLMpivbGw4Uri09n2LuKW/5qVWBr6BrIsZshBuMSrxfxORNoOQs2M3K3AjR2aydVX/nP8Ea82sHSC+wYEXodIo26pw/GV4YPpLMx98mtjfefgRxEIRQu47Lp43SY9Yh95sc2XjH8z+YoE+3shzcsMp8wRtdkh+svHSl9yoCBws9kRHNiZP1Ic8vMWahsQ3Z6NkljeapbauFfP7wanx8G+H8nNbNkivHdNk4u3f/LsCmmQ/MtTybS0pKJN+QhswYXnph1QfmEPost/p88vi7zLLvJ3y1Fy6GaBCKHfZ1ZaCp5eJcKGnYDcLRAESVi1vDQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nk/u+QtZ1lvYZqSAgyQE47Vd/7BSWts4s/uS5sJvl0w=; b=SFsudj/GqhPltQhbZPueWeUs+yeIdDCeSGzZSS2HURLkyx1qghNpAJ7lGRpOIWDshg/rfajtn8Z1/ELU7ucjaDPDwNYHtyDUQ/5cAUC6UhqXLbriHnGxXKGV7l7SbtO3+0rg111kOOTOQdV1Q6MGibU7TJbKpL39q4WNy2LR9wzkMeI/kdIaVBjHb1VMNkO/MO26XmqYO7dYZ3JrA+AUWu9GlX+Aqw0JQDChyV2IJYrdJ4Nb0yZw8qeTZOt6bHYT+hYz7iOusQAT9/1CoUST8GFjzVWZDFCCSwKiLP2In2ROkASQWGD9R8q1GfoMp8sHZybxZxsspZ2AQ98Cx7Alsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nk/u+QtZ1lvYZqSAgyQE47Vd/7BSWts4s/uS5sJvl0w=; b=US5zSooozVK8EEXON0xmtRlUpGoD0F6N9jN/mZIrNgCYKnaQbvfmKVJk2M/aLBS0k56tEJHZywneAd9Rn6yvXKb+1F3VhV8LlFYvwthmREp89+tfZcb6RIPjLszcL+56gBJJX2CoKyvgrPEnxVAofzV+RQs2SwBPEGIeV7s+RWU= Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by PH7PR10MB5699.namprd10.prod.outlook.com (2603:10b6:510:127::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Tue, 25 Jul 2023 22:23:57 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::827f:8665:2052:16c5]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::827f:8665:2052:16c5%4]) with mapi id 15.20.6609.032; Tue, 25 Jul 2023 22:23:57 +0000 Message-ID: <2e869548-5613-5f84-7210-490b23a789d9@oracle.com> Date: Tue, 25 Jul 2023 15:23:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/2] bpf: don't print () in bpf_print_operand_address Content-Language: en-US To: "Jose E. Marchesi" Cc: gcc-patches@gcc.gnu.org References: <20230725220821.11431-1-david.faust@oracle.com> <874jlrabae.fsf@oracle.com> From: David Faust In-Reply-To: <874jlrabae.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR08CA0053.namprd08.prod.outlook.com (2603:10b6:5:1e0::27) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|PH7PR10MB5699:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d4e99a1-9410-4eac-9bd8-08db8d5dd666 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3A7oX0aZu578LBexhV+Mcb9l6xzg7kr0xd/L+ciYw5iI74Sd5hJCKCuK8JPpsZi9SmdAuYb/qHWix+1tAXkx3zWusZ5+DTpp0mdclRHwMZfazqrGaVP69lL/m7jfc8t48sZ8N4DqYUA+oMBOF+tZckdBPOkpYVYoX1C0JHF2beSDjk9runkF0KPtqjt6D14Li5NQ0qpRaNzgiAY3oKqbvkVzkM0E4YbiLjZw74DdDdwY5EbDDNZFkkz00kDkZD76J1TwZnKX2X7F7i8Zz711g5UziOuDr9i9Vae+0QPLY14t3nOyg9hclvqsIEQg8uEjGsNovmbzGphAg6iUFvAtmJyue73oFS+YHcLlUWATFnGUiKgCaQ84El5XAGpFIoofIyASEelJghe0IoNR4kKTkqHHmk6nwusWz1PwTEWXiV0iPnX36ypVIoz2tZ4hLng1zzdI53B5/E3EneMWazzrb+YLEPDPEYoqvOOSmXwqDVBSVueICQ/IpnWHJNO1LTVvpdM/6wOQzDfqEXB/rPeumHESlS9i6BrwYbnSiL5fUEuTbn3ItLd2ps4HXoTMphmu1JMrY13cOsuvjNuNMpM3n5pyrjj19Uddvc4D55xYsMB97pdXUO1yx0AurCJVR2+ZDB2CuofPPLhbPbP/sndXRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3213.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199021)(478600001)(31696002)(37006003)(86362001)(6666004)(6486002)(36756003)(316002)(66946007)(66476007)(6636002)(4326008)(6512007)(41300700001)(66556008)(26005)(6862004)(6506007)(8936002)(186003)(5660300002)(8676002)(53546011)(44832011)(38100700002)(31686004)(2906002)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmZLSG9ySCt6QWtDeW9TdWVqaHZWUkdsTHp6eHRIVHZia2ZBUTVhRVdPMDNX?= =?utf-8?B?MGU4RE4yUUJJcU84N21Kb2FIRzBEVC9yS09pNW1ZbE9oUGFVYUxWUUZya3pw?= =?utf-8?B?L09zaGNKaXo1WWlaOVFrUFRKR0tMMVVXcXRWdGZIbUljRVBpZjZ4am54UnZo?= =?utf-8?B?bmtEK1FFZ2g3ZEphSmsvMHVpQlFSMm9sRFhkOXNOOG1LSnhGVndQdEtiaVJq?= =?utf-8?B?QzlTMC9DYkhnRFBUN2txbG5wdVgyOWRQZkxZbnQ2ZXdRZnpkdEk3djZlT2lr?= =?utf-8?B?RElrVWd2RFZTMDNpOFpqWHNQamxUZFJQeXBOSXJqSFlwTG4zdkpLOUZTZW5M?= =?utf-8?B?UmJndjVjekJybm1sd2dWT1FlK0owN1hVODNVdjgwS2trYmUzb2tIdDc0UDhl?= =?utf-8?B?dytPek90V3BCaGw3TnhHWlQrSEphNm9aM2tDc2JBODdtekpLWGgvTU8wYXJU?= =?utf-8?B?eC8wYjBvNFVNTWNYc0NBMEZlTG1wbXZoMC9zL01nUHk3WTZFbGJJRDZLbWdW?= =?utf-8?B?d2NCQW1SSG9zQzNzNzlqZFBPKzdsVjdZdmFRV09yRFIwMVZUWk5Tb3pQaWsz?= =?utf-8?B?RWhtM3NDV1pkU09CaHB2LzNEczB5WEI5ZjFKa0ZGRVFIZ0EzTlV6aHNqcXho?= =?utf-8?B?OG85QzV1ZWlXR1JHdCs0ellNQVpuRUxQdGhKVDEzTm1ZS1RIU0twb1UycGNl?= =?utf-8?B?dW0xNU0yOEs4djM1WDNnOHdreUM5ZHlmTzQyd1BVNHA4UUZuTTN6czFtN1VI?= =?utf-8?B?ZDRkQldDWk1CKzlBcWlzendRb3NVZk9UMWlUUzNEaVhsOEFnWVBUMjhHeHlV?= =?utf-8?B?cnpCOHFvYlI1QmZpb3ppU1dlbUxXY2d4MnArU0JTSEt1U3pMc2FpUFJQaDJW?= =?utf-8?B?UFlMK0ZteUR5ZUkyL1BNRVZZL0t0VEg5b3hoUlI0UmVLbkIwWFBmRHEyMHNS?= =?utf-8?B?QkQ2M3U1c3ZyUk9sbHRtbmtWQlUrMUhDS1hNNW9MNnh0eW9UNnBqM0dRMTF5?= =?utf-8?B?YlQvVzg4V3lHWUpWUVlVdjR5a0FFOSt4MWl5ZWlIcThzTEZud3kwSUVOa1Js?= =?utf-8?B?Qy9ZUm51NVJGa3d5TysxMVRvZzhmdGZjRkkzTlBlWnRTSU12M1R6MGh0anF0?= =?utf-8?B?Sms5VWx1T1BSRU9GS0hxek1ibHZ6dmxpQytsVDVzMXNOUW52d0toaHdkZjJY?= =?utf-8?B?UE5vYzZJMTZhYlpKekxOc01MUVhJUjBzb3kyR2RCdFNEWWNNZWR3NXpmTGdF?= =?utf-8?B?aFNxQmJwRFlXTkpTUk94REg5bHpSSEphYkl1U0RZekx4Ry81S0NPWVM2OG4z?= =?utf-8?B?dlpmWUR4UkIrVVpCMGFKTnRoV1JmVENFODJzWnY5Qy8zWmxwenJNcEVLMmRu?= =?utf-8?B?R3dnUGRGZGdIc0hkY1g0WGFJbzdTVXVhdzh5Zk0wWGRnelJuSy85ZE1NOU8w?= =?utf-8?B?bGxBY3lIZFQyelIzc1d2dmZDUWt4THdGQk5rOWhhWWVoQ2tIMXorbXZaeFRa?= =?utf-8?B?cEptNUF5QjZiM000Y0svR29vNllCYnladmt5cVhoaERjMnltdFhERU9WejRu?= =?utf-8?B?ZTFMTVNZM3IyYmRwcDhlMlo5TTI3WXBvYjdITTVNd0c0b0Z3WmxCWHVQN3ZZ?= =?utf-8?B?UW5mMk1SL29SN1duOTVqOEprVzJEWFhCQURJeFFQdEt2T1RqMmEwQXpqRzRP?= =?utf-8?B?eldlWWIwYUlOS0F5NzZ5bG5hMElUcy81eTdQVjJTS0Vmd0F5SHA2UU1valhx?= =?utf-8?B?NzlWODB6alFOL3ZLVHFYQ1A5dnZGQW1RM0p4Q3l5ajF3Vm5yMlp3T0lrdWxk?= =?utf-8?B?MlF1WXVJbWlDeDNGUS85VzVwbCtjdEZBLzdsdXFLckc5ZWZSdi9peXVubkRO?= =?utf-8?B?a1hQT244VUphSVJhZzFiNnc4S3g4eFkrOU9KYXpJL0I5UWZ3SHEyenNxbVpX?= =?utf-8?B?NklQVUFmWGhYcVNremEvVW1tV0xSUG1ZeHNMeVRUZEh5d0xKMkxJMGY0Y2Zj?= =?utf-8?B?TUlOMWczdy9sV1hGWjB5UHpSTnltcWFVbUpNTGtlbUdOYVlUcFV0bkN6WThE?= =?utf-8?B?RDRwbzA5Vnd1OTZsQzVLb1dKblBjUHFWejR3RFFnSWJXUHBOU1dFcnRGSVlH?= =?utf-8?Q?xvxhGAS9Bmtt5LaI7w/CzR/kK?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LLlb6XC2bA9SDb031tpCze0hMhiIMAwJtujR32F+ohjbsGEW7F5PjdQ3Ce32500EASS7bWorX4lz+LlnBFccn9R6xF0CaE6iDhdPIkRWE/kNLFn/2gd466HxrbujhMz9/8YZNCm93QcL10z9w/sJJIqZNMDblA/TorGtDh4HaQuW6b1q8R+GLa6d1CqhoYpIkJSMaW75ahAk9KuKy5UvzUl0DXjk8j9QFmCpWqM9+89udPOBlqyLYJvmpuGEV+43+Q/XRiVRR4+CZTPMK/499NTThjahvRUX2xDCSOVKlSgd9LkO1V6ol+YJBoMx16RZyjOlmSjur1hv8BmAsmrwegclV1DuokQ54kdmT5DKaHI986QIZ70uILw4SwA+kmzky4AljhxemIlkBBz7zJtTjAvSwyRaERR+OgrdY1E7QnxtBz8WSnKxfSRAqHstdxZgJvQRdWwlL99UUT0F8oQzQrdTRlJV8J0P8dPfAHxvELXDJt0L0f4bCzw6he99VT7Q3zBgDpYRTw8lXpeKilVIj0gBTWommdt7nV2hE9KTGCHSl8N2cNdIvXCMGxou/wcDD2L7TfMW0Qy/MWCkfsi6e8GIrSP7CnxUcc8erTnjVecZlrENYqUZPtfMgkrpNSebXV1BoMYUXYBIdvDf/JNOnvyFN5JQ7rrWFZC4kpPEO2EOWisKXTVyH94C5mlu1Eftuiq83VdVLveGSfoysONjjwzpee9/Gtm8WnWTaskuEmQXqXMNBjnUoJZ5CvY/DDAj X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d4e99a1-9410-4eac-9bd8-08db8d5dd666 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 22:23:57.3449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HZAF5hCV/lka0fLpeZDNaN/KstZSMCZBT75q4oCOBZhRulTPulpaQPOFZd83XcX0/DPS3GXXlsc3gpW3W3fIXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5699 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_12,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250192 X-Proofpoint-ORIG-GUID: EYRKdTB6luXje0E3pka2GV5Qg8WSSnkt X-Proofpoint-GUID: EYRKdTB6luXje0E3pka2GV5Qg8WSSnkt X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/25/23 15:14, Jose E. Marchesi wrote: > > Hi David. > >> Unfortunately, the pseudo-C dialect syntax used for some of the v3 >> atomic instructions clashes with unconditionally printing the >> surrounding parentheses in bpf_print_operand_address. >> >> Instead, place the parentheses in the output templates where needed. >> >> Tested in bpf-unknown-none. >> OK? >> >> gcc/ >> >> * config/bpf/bpf.cc (bpf_print_operand_address): Don't print >> enclosing parentheses for pseudo-C dialect. >> * config/bpf/bpf.md (zero_exdendhidi2): Add parentheses around >> operands of pseudo-C dialect output templates where needed. >> (zero_extendqidi2): Likewise. >> (zero_extendsidi2): Likewise. >> (*mov): Likewise. >> --- >> gcc/config/bpf/bpf.cc | 8 ++++---- >> gcc/config/bpf/bpf.md | 12 ++++++------ >> 2 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc >> index 55b6927a62f..2c077ea834e 100644 >> --- a/gcc/config/bpf/bpf.cc >> +++ b/gcc/config/bpf/bpf.cc >> @@ -933,9 +933,9 @@ bpf_print_operand_address (FILE *file, rtx addr) >> switch (GET_CODE (addr)) >> { >> case REG: >> - fprintf (file, asm_dialect == ASM_NORMAL ? "[" : "("); >> + fprintf (file, asm_dialect == ASM_NORMAL ? "[" : ""); > > We can save the call to fprintf there with a conditional. Good point, thanks. I will update these before pushing. > >> bpf_print_register (file, addr, 0); >> - fprintf (file, asm_dialect == ASM_NORMAL ? "+0]" : "+0)"); >> + fprintf (file, asm_dialect == ASM_NORMAL ? "+0]" : "+0"); >> break; >> case PLUS: >> { >> @@ -944,11 +944,11 @@ bpf_print_operand_address (FILE *file, rtx addr) >> >> if (GET_CODE (op0) == REG && GET_CODE (op1) == CONST_INT) >> { >> - fprintf (file, asm_dialect == ASM_NORMAL ? "[" : "("); >> + fprintf (file, asm_dialect == ASM_NORMAL ? "[" : ""); > > Likewise. > >> bpf_print_register (file, op0, 0); >> fprintf (file, "+"); >> output_addr_const (file, op1); >> - fprintf (file, asm_dialect == ASM_NORMAL ? "]" : ")"); >> + fprintf (file, asm_dialect == ASM_NORMAL ? "]" : ""); >> } >> else >> fatal_insn ("invalid address in operand", addr); >> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md >> index 64342ea1de2..579a8213b09 100644 >> --- a/gcc/config/bpf/bpf.md >> +++ b/gcc/config/bpf/bpf.md >> @@ -260,7 +260,7 @@ (define_insn "zero_extendhidi2" >> "@ >> {and\t%0,0xffff|%0 &= 0xffff} >> {mov\t%0,%1\;and\t%0,0xffff|%0 = %1;%0 &= 0xffff} >> - {ldxh\t%0,%1|%0 = *(u16 *) %1}" >> + {ldxh\t%0,%1|%0 = *(u16 *) (%1)}" >> [(set_attr "type" "alu,alu,ldx")]) >> >> (define_insn "zero_extendqidi2" >> @@ -270,7 +270,7 @@ (define_insn "zero_extendqidi2" >> "@ >> {and\t%0,0xff|%0 &= 0xff} >> {mov\t%0,%1\;and\t%0,0xff|%0 = %1;%0 &= 0xff} >> - {ldxh\t%0,%1|%0 = *(u8 *) %1}" >> + {ldxh\t%0,%1|%0 = *(u8 *) (%1)}" >> [(set_attr "type" "alu,alu,ldx")]) >> >> (define_insn "zero_extendsidi2" >> @@ -280,7 +280,7 @@ (define_insn "zero_extendsidi2" >> "" >> "@ >> * return bpf_has_alu32 ? \"{mov32\t%0,%1|%0 = %1}\" : \"{mov\t%0,%1\;and\t%0,0xffffffff|%0 = %1;%0 &= 0xffffffff}\"; >> - {ldxw\t%0,%1|%0 = *(u32 *) %1}" >> + {ldxw\t%0,%1|%0 = *(u32 *) (%1)}" >> [(set_attr "type" "alu,ldx")]) >> >> ;;; Sign-extension >> @@ -319,11 +319,11 @@ (define_insn "*mov" >> (match_operand:MM 1 "mov_src_operand" " q,rI,B,r,I"))] >> "" >> "@ >> - {ldx\t%0,%1|%0 = *( *) %1} >> + {ldx\t%0,%1|%0 = *( *) (%1)} >> {mov\t%0,%1|%0 = %1} >> {lddw\t%0,%1|%0 = %1 ll} >> - {stx\t%0,%1|*( *) %0 = %1} >> - {st\t%0,%1|*( *) %0 = %1}" >> + {stx\t%0,%1|*( *) (%0) = %1} >> + {st\t%0,%1|*( *) (%0) = %1}" >> [(set_attr "type" "ldx,alu,alu,stx,st")]) >> >> ;;;; Shifts > > Otherwise, LGTM. > OK. > > Thanks!