public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Jan Hubicka <hubicka@ucw.cz>,
	Richard Biener <richard.guenther@gmail.com>
Cc: GCC Mailing List <gcc@gcc.gnu.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	"giuliano.belinassi@usp.br >> Giuliano Belinassi"
	<giuliano.belinassi@usp.br>
Subject: Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)
Date: Fri, 20 Aug 2021 16:54:50 +0200	[thread overview]
Message-ID: <2ea275e0-9918-b4e1-09d9-a4f923a094e5@suse.cz> (raw)
In-Reply-To: <5733a1c6-0e57-d66c-749c-13f2e107650b@suse.cz>

On 8/16/21 3:58 PM, Martin Liška wrote:
> PING^2
> 
> @Honza: Can you please review the change?

I've tested the patch and apparently it's not enough for {gimple,generic}-match.o not clashing
in symbol names. Apparently there are more IPA clones that collide.

Leaving that for now.

Martin

> 
> Martin
> 
> On 6/23/21 3:53 PM, Martin Liška wrote:
>> On 5/21/21 10:29 AM, Martin Liška wrote:
>>> On 5/20/21 5:55 PM, Jan Hubicka wrote:
>>>> Quick solution is to also modify partitioner to use the local symbol
>>>> names when doing incremental linking (those mixing in source code and
>>>> random seeds) to avoid clashes.
>>>
>>> Good hint. I added hash based on object file name (I don't want to handle
>>> proper string escaping) and -frandom-seed.
>>>
>>> What do you think about the patch?
>>> Thanks,
>>> Martin
>>
>> @Honza: Can you please take a look at this patch?
>>
>> Cheers,
>> Martin
> 


  reply	other threads:[~2021-08-20 14:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+=Sn1=+tuqG7qu5C6_atWzJp+af1P6oVPvABHxqNxiUmJb1dg@mail.gmail.com>
     [not found] ` <CAFiYyc1DC1W==r37RhVX9epv1F5XSQhr1XeZEKCk1QOBObSKaQ@mail.gmail.com>
     [not found]   ` <20210511145904.GM10366@gate.crashing.org>
     [not found]     ` <CAFiYyc12G6qAeCevEH0-oE4kX7KN1gafBHN4UNYnQJWQVujffg@mail.gmail.com>
     [not found]       ` <20210512121248.GU10366@gate.crashing.org>
2021-05-20 12:34         ` Martin Liška
2021-05-20 12:54           ` Richard Biener
2021-05-20 13:06             ` Martin Liška
2021-05-20 13:16               ` Richard Biener
2021-05-20 13:22                 ` Richard Biener
2021-05-20 15:55                   ` Jan Hubicka
2021-05-21  8:29                     ` Martin Liška
2021-06-01  7:31                       ` Martin Liška
2021-06-23 13:53                       ` Martin Liška
2021-08-16 13:58                         ` Martin Liška
2021-08-20 14:54                           ` Martin Liška [this message]
2021-08-22 13:09                       ` Jan Hubicka
2021-06-12 15:55                 ` Giuliano Belinassi
2021-05-21  8:43             ` Martin Liška
2021-05-21 12:35               ` David Edelsohn
2021-05-24  8:07                 ` Martin Liška
2021-06-01  7:33               ` Martin Liška
2021-06-01  7:42                 ` Richard Biener
2021-06-01 11:25                   ` Martin Liška
2021-06-01 13:19                     ` Richard Biener
2021-08-20 14:57                       ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ea275e0-9918-b4e1-09d9-a4f923a094e5@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=giuliano.belinassi@usp.br \
    --cc=hubicka@ucw.cz \
    --cc=richard.guenther@gmail.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).