public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Thomas Schwinge <thomas@codesourcery.com>, gcc-patches@gcc.gnu.org
Cc: Iain Sandoe <idsandoe@googlemail.com>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	Mike Stump <mikestump@comcast.net>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: [PING] libatomic: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951]
Date: Thu, 26 Oct 2023 07:34:31 -0600	[thread overview]
Message-ID: <2ed9011b-4aa3-4b7d-97fb-b61ff3f88caa@gmail.com> (raw)
In-Reply-To: <87v8avw18l.fsf@euler.schwinge.homeip.net>



On 10/25/23 02:32, Thomas Schwinge wrote:
> Hi!
> 
> Ping.
> 
> 
> Grüße
>   Thomas
> 
> 
> On 2023-09-12T13:03:28+0200, I wrote:
>> Hi!
>>
>> On 2020-04-04T00:00:44+0100, "Maciej W. Rozycki via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
>>> Fix a problem with the libatomic testsuite using a method to determine
>>> the compiler to use resulting in the tool being different from one the
>>> library has been built with, and causing a catastrophic failure from the
>>> lack of a suitable `--sysroot=' option where the `--with-build-sysroot='
>>> configuration option has been used to build the compiler resulting in
>>> the inability to link executables.
>>>
>>> Address this problem by providing a DejaGNU configuration file defining
>>> the compiler to use, via the GCC_UNDER_TEST TCL variable, set from $CC
>>> by autoconf, which will have all the required options set for the target
>>> compiler to build executables in the environment configured
>>
>> As we've found, this is conceptually problematic, as discussed in
>> <https://inbox.sourceware.org/875y868a4b.fsf@euler.schwinge.homeip.net>
>> "Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.)
>> [PR109951]".
>> I therefore suggest to apply to libatomic the conceptually same changes
>> as I've just pushed for libgomp:
>> <https://inbox.sourceware.org/874jjzzqc2.fsf@euler.schwinge.homeip.net>
>> "libgomp: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC'
>> etc.) [PR91884, PR109951]".
>> OK to push the attached
>> "libatomic: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951]"?
Also OK.

Jeff

  reply	other threads:[~2023-10-26 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 23:00 [PATCH v4 0/5] Fix library testsuite compilation for build sysroot Maciej W. Rozycki
2020-04-03 23:00 ` [PATCH v4 1/5] libatomic/test: Fix " Maciej W. Rozycki
2020-04-06 18:10   ` Jeff Law
2020-04-06 22:34     ` Maciej W. Rozycki
2023-09-12 11:03   ` libatomic: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951] (was: [PATCH v4 1/5] libatomic/test: Fix compilation for build sysroot) Thomas Schwinge
2023-10-25  8:32     ` [PING] " Thomas Schwinge
2023-10-26 13:34       ` Jeff Law [this message]
2020-04-03 23:01 ` [PATCH v4 GCC 2/5] libffi/test: Fix compilation for build sysroot Maciej W. Rozycki
2020-04-06 18:06   ` Jeff Law
2020-04-06 20:21     ` Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 GCC 3/5] libffi/test: Make `libffi-init' use $CC_FOR_TARGET Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 4/5] libgo/test: Complement compilation fix for build sysroot Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 5/5] libgomp/test: Remove a build sysroot fix regression Maciej W. Rozycki
2020-04-06 18:11   ` Jeff Law
2020-04-06 22:34     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ed9011b-4aa3-4b7d-97fb-b61ff3f88caa@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=idsandoe@googlemail.com \
    --cc=macro@orcam.me.uk \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).