From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6CFB538582AF for ; Mon, 13 Jun 2022 18:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6CFB538582AF Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-7FIgpm2ON1iVmk9MVpQfDg-1; Mon, 13 Jun 2022 14:28:33 -0400 X-MC-Unique: 7FIgpm2ON1iVmk9MVpQfDg-1 Received: by mail-qk1-f198.google.com with SMTP id t15-20020a05620a450f00b006a75bf35680so5648569qkp.1 for ; Mon, 13 Jun 2022 11:28:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=dngomXJvhJKDg48c72P/jjV6n15BET19SNEWiX1Mf6c=; b=gXIEEGw23A2VfRuOPGHtjHEAkgUU5kNnTIUvQQu0DG9yNTtYBYlJ4KNW84K22hHjIe g/lOIQYzBhw6l0ZTG/SvHp1zbNpczbRyxRZH668Z3H6f4VwpORC0gYwX+EAgrlM6P8w1 frY7DG8sE+fW31XvrnjGbODkQEWp1XFhezMTbTo5q25ZK0M8PShjJN9vLXTGiLpYg1Lm c8TfPvfm4dOLY6cuy6r88vCTIF3xbU5fx5MzD4uq3gFsxX0ZlDH3+g0sXK1qLlGSqgzk MkKQGsDvZtpGG1TRnRk+qSPYe60pprcqzQOtiNLcNU3M20m6QUYDVZbB7++Io+2xBjaj 728g== X-Gm-Message-State: AOAM533LlidfpGDOiVqVkr6AmCo3LfQ17v5vP3nisDMQ2mX9QqEAQvVN o4DEGGJhLDxx35TZv08cWJX0Lg2bglU3up3bj6FcVoZvcK0aBPD0zmso040yM+k3o73F0rtFziq nChIBkEPUZIWD/BY07G2Z4w5EgzGGneZ81wRA24zWVlMBOrYPF6Xve1FYfDm6w7yArZ/fvg== X-Received: by 2002:ac8:5e4b:0:b0:304:f179:4e9a with SMTP id i11-20020ac85e4b000000b00304f1794e9amr997305qtx.490.1655144912062; Mon, 13 Jun 2022 11:28:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJmbpWrFPwgGMjKnF7Sw1eeaqLH2ZmA2MMBgh9/zNIrDP5DSk0c3aL0vEzqtiGerAsJVIqSw== X-Received: by 2002:ac8:5e4b:0:b0:304:f179:4e9a with SMTP id i11-20020ac85e4b000000b00304f1794e9amr997290qtx.490.1655144911769; Mon, 13 Jun 2022 11:28:31 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id o22-20020a05620a2a1600b006a6ae9150fesm7779945qkp.41.2022.06.13.11.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 11:28:31 -0700 (PDT) Message-ID: <2edbd394896697ef6c72c3203a2fd22ecdb637fb.camel@redhat.com> Subject: PING Re: [PATCH 07/10] value-relation.h: add 'final' and 'override' to relation_oracle vfunc impls From: David Malcolm To: gcc-patches@gcc.gnu.org, Andrew MacLeod , Aldy Hernandez Date: Mon, 13 Jun 2022 14:28:30 -0400 In-Reply-To: <20220523192834.3785673-8-dmalcolm@redhat.com> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-8-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 18:28:36 -0000 Ping re this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595438.html OK for trunk? Thanks Dave On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > gcc/ChangeLog: >         * value-relation.h: Add "final" and "override" to > relation_oracle >         vfunc implementations as appropriate. > > Signed-off-by: David Malcolm > --- >  gcc/value-relation.h | 38 +++++++++++++++++++++----------------- >  1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/gcc/value-relation.h b/gcc/value-relation.h > index 19762d8ce2b..478729be0bf 100644 > --- a/gcc/value-relation.h > +++ b/gcc/value-relation.h > @@ -130,14 +130,15 @@ public: >    equiv_oracle (); >    ~equiv_oracle (); >   > -  const_bitmap equiv_set (tree ssa, basic_block bb); > +  const_bitmap equiv_set (tree ssa, basic_block bb) final override; >    void register_relation (basic_block bb, relation_kind k, tree ssa1, > -                         tree ssa2); > +                         tree ssa2) override; >   > -  relation_kind query_relation (basic_block, tree, tree); > -  relation_kind query_relation (basic_block, const_bitmap, > const_bitmap); > -  void dump (FILE *f, basic_block bb) const; > -  void dump (FILE *f) const; > +  relation_kind query_relation (basic_block, tree, tree) override; > +  relation_kind query_relation (basic_block, const_bitmap, > const_bitmap) > +    override; > +  void dump (FILE *f, basic_block bb) const override; > +  void dump (FILE *f) const override; >   >  protected: >    bitmap_obstack m_bitmaps; > @@ -185,14 +186,16 @@ public: >    dom_oracle (); >    ~dom_oracle (); >   > -  void register_relation (basic_block bb, relation_kind k, tree op1, > tree op2); > +  void register_relation (basic_block bb, relation_kind k, tree op1, > tree op2) > +    final override; >   > -  relation_kind query_relation (basic_block bb, tree ssa1, tree ssa2); > +  relation_kind query_relation (basic_block bb, tree ssa1, tree ssa2) > +    final override; >    relation_kind query_relation (basic_block bb, const_bitmap b1, > -                                  const_bitmap b2); > +                               const_bitmap b2) final override; >   > -  void dump (FILE *f, basic_block bb) const; > -  void dump (FILE *f) const; > +  void dump (FILE *f, basic_block bb) const final override; > +  void dump (FILE *f) const final override; >  private: >    bitmap m_tmp, m_tmp2; >    bitmap m_relation_set;  // Index by ssa-name. True if a relation > exists > @@ -229,15 +232,16 @@ class path_oracle : public relation_oracle >  public: >    path_oracle (relation_oracle *oracle = NULL); >    ~path_oracle (); > -  const_bitmap equiv_set (tree, basic_block); > -  void register_relation (basic_block, relation_kind, tree, tree); > +  const_bitmap equiv_set (tree, basic_block) final override; > +  void register_relation (basic_block, relation_kind, tree, tree) > final override; >    void killing_def (tree); > -  relation_kind query_relation (basic_block, tree, tree); > -  relation_kind query_relation (basic_block, const_bitmap, > const_bitmap); > +  relation_kind query_relation (basic_block, tree, tree) final > override; > +  relation_kind query_relation (basic_block, const_bitmap, > const_bitmap) > +    final override; >    void reset_path (); >    void set_root_oracle (relation_oracle *oracle) { m_root = oracle; } > -  void dump (FILE *, basic_block) const; > -  void dump (FILE *) const; > +  void dump (FILE *, basic_block) const final override; > +  void dump (FILE *) const final override; >  private: >    void register_equiv (basic_block bb, tree ssa1, tree ssa2); >    equiv_chain m_equiv;