From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 9C3403858D32 for ; Sat, 18 Nov 2023 17:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C3403858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C3403858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700328249; cv=none; b=PIF5u3gQPQg8Ep1gqVLIwYo1Ldn04IzMPPJRNcDXquvpgQphniz7HGTiZwYFKECcOBAJkao4MGtzyE3XD3NgXu2Xr5h/hCIvRKqA34rTgxafI7gpVOdsQQBnFurnKS+Im++rDZNduA5Z4eXb1sT2cNPu8QrK3fWHGftT/VB0sIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700328249; c=relaxed/simple; bh=UA0RspXhkJ4iB0CdFPYJS4T7PiN2FpoPkjNTisE8MOo=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=J4jQVZXVGWPLgmNYilXr6SCtdsAhC8oDeJMBge5qmi7bSGsKp0gRYpFm8tuBDqS8THxpd8TILhaJBuyCkIJ+aSmT4aIf8FoZCu+2Sv2G0BDaBkiVpS12CsiWioTykMmAj1bGtBOOSB+VPxYcbZ0x6k2cmOaljVph22HVVoPBx+Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700328244; bh=UA0RspXhkJ4iB0CdFPYJS4T7PiN2FpoPkjNTisE8MOo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Cq9nYmkjUg0RQfPYpNG9CI6InXZJldA+GSTMQeC7UD+6qsbgmwiI66Q4XZHv9cSSh KKnCQK4T5K1tPWyRQFYyIDwdSzshX1X5eDttazgWVBFOFLvW0QpMKES6OFT6PVbde9 Shw4a7NUOCZaoHpjLDwUyia3aUJOxO9dDVPFOXx8= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id BA02866B06; Sat, 18 Nov 2023 12:24:03 -0500 (EST) Message-ID: <2efc73688c6891980d84cd7cd0cbc66bc5283b1f.camel@xry111.site> Subject: Re: [pushed][PATCH v2] LoongArch: Add code generation support for call36 function calls. From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Sun, 19 Nov 2023 01:24:02 +0800 In-Reply-To: <4a04776c-810d-5c3c-6132-646cf52fbe5c@loongson.cn> References: <20231116072745.6177-1-chenglulu@loongson.cn> <4a04776c-810d-5c3c-6132-646cf52fbe5c@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 2023-11-18 at 16:16 +0800, chenglulu wrote: > Pushed to r14-5567. >=20 > =E5=9C=A8 2023/11/16 =E4=B8=8B=E5=8D=883:27, Lulu Cheng =E5=86=99=E9=81= =93: > > When compiling with '-mcmodel=3Dmedium', the function call is made thro= ugh > > 'pcaddu18i+jirl' if binutils supports call36, otherwise the > > native implementation 'pcalau12i+jirl' is used. > >=20 > > gcc/ChangeLog: > >=20 > > * config.in: Regenerate. > > * config/loongarch/loongarch-opts.h (HAVE_AS_SUPPORT_CALL36): Define m= acro. > > * config/loongarch/loongarch.cc (loongarch_legitimize_call_address): > > If binutils supports call36, the function call is not split over expan= d. > > * config/loongarch/loongarch.md: Add call36 generation code. > > * config/loongarch/predicates.md: Likewise. > > * configure: Regenerate. > > * configure.ac: Check whether binutils supports call36. With this change I get some test failures with "old" Binutils 2.41: FAIL: gcc.target/loongarch/func-call-medium-1.c scan-assembler test:.*la.gl= obal\\t.*g\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-1.c scan-assembler test1:.*la.g= lobal\\t.*f\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-1.c scan-assembler test2:.*la.l= ocal\\t.*l\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-2.c scan-assembler test:.*la.gl= obal\\t.*g\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-2.c scan-assembler test1:.*la.l= ocal\\t.*f\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-2.c scan-assembler test2:.*la.l= ocal\\t.*l\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-3.c scan-assembler test2:.*la.l= ocal\\t.*l\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-4.c scan-assembler test1:.*la.l= ocal\\t.*f\\n\\tjirl FAIL: gcc.target/loongarch/func-call-medium-4.c scan-assembler test2:.*la.l= ocal\\t.*l\\n\\tjirl Some strange thing is happening: with -mexplicit-relocs=3Dauto or always I get pcalau12i + jirl as expected, but with -mexplicit-relocs=3Dnone I get "pcaddu18i $r1,%call36(g)" and jirl. This seems irony (!). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University