public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: JonY <10walls@gmail.com>
To: Lokesh Janghel <lokeshjanghel91@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, Jakub Jelinek <jakub@redhat.com>,
	mateuszb@poczta.onet.pl,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] Bug 88521 - gcc 9.0 from r266355 miscompile x265 for mingw-w64 target
Date: Sat, 29 Dec 2018 02:34:00 -0000	[thread overview]
Message-ID: <2f123f3a-701a-67cb-a17d-4d540452da50@gmail.com> (raw)
In-Reply-To: <CACcU4_qAPCjELr-KTAiR3gZVa96zy5mQf_CUcCRvX1Umcr4Xwg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]

On 12/26/18 1:10 PM, Lokesh Janghel wrote:
> Hi,
> 
> Here is the patch for the issue.
> Please let me know your thoughts.
> 
> On Fri, Dec 21, 2018 at 3:16 PM JonY <10walls@gmail.com> wrote:
>>
>> On 12/21/18 9:08 AM, Uros Bizjak wrote:
>>> On Thu, Dec 20, 2018 at 1:09 PM Jakub Jelinek <jakub@redhat.com> wrote:
>>>>
>>>> On Thu, Dec 20, 2018 at 01:42:15PM +0530, Lokesh Janghel wrote:
>>>>> Hi Mateuszb,
>>>>>
>>>>> I tested with your proposition patch and it is working right.
>>>>> I also added the patch with test case.
>>>>> Please let me know your thoughts/suggestions.
>>>>
>>>> ChangeLog entry is missing, please write it (and mention there
>>>> Mateusz's name/mail as he wrote the i386.c part).
>>>>
>>
>> Patch looks good to me, but please add a ChangeLog.
>>
>>
> 
> 

Changelog OK too.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-12-29  1:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  8:12 Lokesh Janghel
2018-12-20  8:31 ` Mateusz
2018-12-20 12:16 ` Jakub Jelinek
2018-12-21  9:14   ` Uros Bizjak
2018-12-21  9:15     ` Jakub Jelinek
2018-12-21 10:05     ` JonY
2018-12-26 16:19       ` Lokesh Janghel
2018-12-29  2:34         ` JonY [this message]
2019-01-07  7:31           ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f123f3a-701a-67cb-a17d-4d540452da50@gmail.com \
    --to=10walls@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=lokeshjanghel91@gmail.com \
    --cc=mateuszb@poczta.onet.pl \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).