From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13217 invoked by alias); 25 May 2017 10:00:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13176 invoked by uid 89); 25 May 2017 10:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=percent X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 10:00:52 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A6210AAB4; Thu, 25 May 2017 10:00:53 +0000 (UTC) To: GCC Patches Cc: Jan Hubicka From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Subject: [PATCH] Bound partial-inlining-entry-probability param (PR ipa/80663). Message-ID: <2f282165-32ab-ceb6-d9d8-50d7e8832745@suse.cz> Date: Thu, 25 May 2017 10:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7E7A74FA0870952FD22303B6" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01939.txt.bz2 This is a multi-part message in MIME format. --------------7E7A74FA0870952FD22303B6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 271 Hello. Having value of parameter partial-inlining-entry-probability bigger than 100 does not make sense and can be just used to artificially trigger partial inlining. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin --------------7E7A74FA0870952FD22303B6 Content-Type: text/x-patch; name="0001-Bound-partial-inlining-entry-probability-param-PR-ip.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Bound-partial-inlining-entry-probability-param-PR-ip.pa"; filename*1="tch" Content-length: 2412 >From 4f849447030daa05f64a095d14d56a4df0583573 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 17 May 2017 13:23:54 +0200 Subject: [PATCH] Bound partial-inlining-entry-probability param (PR ipa/80663). gcc/ChangeLog: 2017-05-17 Martin Liska PR ipa/80663 * params.def: Bound partial-inlining-entry-probability param. gcc/testsuite/ChangeLog: 2017-05-19 Martin Liska * g++.dg/ipa/pr80212.C: Remove the test as it does not longer split at the problematic spot. * gcc.dg/ipa/pr48195.c: Change 101 to 100 as 101 is no longer a valid value of the param. --- gcc/params.def | 2 +- gcc/testsuite/g++.dg/ipa/pr80212.C | 18 ------------------ gcc/testsuite/gcc.dg/ipa/pr48195.c | 2 +- 3 files changed, 2 insertions(+), 20 deletions(-) delete mode 100644 gcc/testsuite/g++.dg/ipa/pr80212.C diff --git a/gcc/params.def b/gcc/params.def index 1b058e49860..6b07518a34b 100644 --- a/gcc/params.def +++ b/gcc/params.def @@ -126,7 +126,7 @@ DEFPARAM (PARAM_COMDAT_SHARING_PROBABILITY, DEFPARAM (PARAM_PARTIAL_INLINING_ENTRY_PROBABILITY, "partial-inlining-entry-probability", "Maximum probability of the entry BB of split region (in percent relative to entry BB of the function) to make partial inlining happen.", - 70, 0, 0) + 70, 0, 100) /* Limit the number of expansions created by the variable expansion optimization to avoid register pressure. */ diff --git a/gcc/testsuite/g++.dg/ipa/pr80212.C b/gcc/testsuite/g++.dg/ipa/pr80212.C deleted file mode 100644 index 60d3b613035..00000000000 --- a/gcc/testsuite/g++.dg/ipa/pr80212.C +++ /dev/null @@ -1,18 +0,0 @@ -// PR ipa/80212 -// { dg-options "-O2 --param partial-inlining-entry-probability=403796683 -fno-early-inlining" } - -struct b -{ - virtual b *c () const; -}; -struct d : virtual b -{ -}; -struct e : d -{ - e * - c () const - { - } -}; -main () { e a; } diff --git a/gcc/testsuite/gcc.dg/ipa/pr48195.c b/gcc/testsuite/gcc.dg/ipa/pr48195.c index 2e38452d598..25e80bab8f8 100644 --- a/gcc/testsuite/gcc.dg/ipa/pr48195.c +++ b/gcc/testsuite/gcc.dg/ipa/pr48195.c @@ -1,5 +1,5 @@ /* { dg-do link } */ -/* { dg-options "-O2 -flto --param partial-inlining-entry-probability=101" } */ +/* { dg-options "-O2 -flto --param partial-inlining-entry-probability=100" } */ /* { dg-require-effective-target lto } */ extern void abort(void); -- 2.12.2 --------------7E7A74FA0870952FD22303B6--