From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83890 invoked by alias); 13 Sep 2018 18:44:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83857 invoked by uid 89); 13 Sep 2018 18:44:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:54be X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 18:44:19 +0000 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8193B3001C20; Thu, 13 Sep 2018 18:44:18 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-75.rdu2.redhat.com [10.10.112.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id F23B530912F4; Thu, 13 Sep 2018 18:44:16 +0000 (UTC) Subject: Re: [PATCH] Check the STRING_CSTs in varasm.c To: Bernd Edlinger , Martin Sebor , Richard Biener Cc: "gcc-patches@gcc.gnu.org" References: <3c743954-cae6-a7b8-3c63-71d170d8e56c@gmail.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <2f4995e8-b081-54be-54ba-34e6e15effeb@redhat.com> Date: Thu, 13 Sep 2018 18:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00718.txt.bz2 On 8/24/18 2:18 PM, Bernd Edlinger wrote: > Hi! > > > This is an alternative approach in making STRING_CST semantics > consistent. > > This means it makes STRING_CST used for literals and for initializers > use exactly the same semantics. > > It makes sure that all STRING_CST have a TYPE_SIZE_UNIT, and that it is > always larger than TREE_STRING_LENGTH, these and certain other properties > are checked in varasm.c, so the currently observed consistency issues > in the middle-end can be resolved. > > > It depends on the following pre-condition patches: [ ... ] > > [PATCHv2] Handle overlength strings in C++ FE > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01567.html I've committed this patch to the trunk. jeff