public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Pat Haugen <pthaugen@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: David Edelsohn <dje.gcc@gmail.com>,
	Segher Boessenkool <segher@kernel.crashing.org>
Subject: Ping^5: [PATCH, rs6000 V2] rotate and mask constants [PR94393]
Date: Wed, 19 Jan 2022 15:04:18 -0600	[thread overview]
Message-ID: <2f6f61f9-3e2f-8bb9-adf7-72ed7fbf7b89@linux.ibm.com> (raw)
In-Reply-To: <6390d35c-3dac-2fb7-c6bd-4263ed284b9e@linux.ibm.com>

Ping. I'll note that I recently discovered that this patch also fixes PR93176 and PR97042.

-Pat

On 11/22/21 1:38 PM, Pat Haugen via Gcc-patches wrote:
> Updated version of the patch. Changes made from original are updated commentary to hopefully aid readability, no functional changes.
> 
> 
> Implement more two insn constants.  rotate_and_mask_constant covers
> 64-bit constants that can be formed by rotating a 16-bit signed
> constant, rotating a 16-bit signed constant masked on left or right
> (rldicl and rldicr), rotating a 16-bit signed constant masked by
> rldic, and unusual "lis; rldicl" and "lis; rldicr" patterns.  All the
> values possible for DImode rs6000_is_valid_and_mask are covered.
> 
> Bootstrapped and regression tested on powerpc64(32/64) and powerpc64le.
> Ok for master?
> 
> -Pat
> 
> 
> 2021-11-22  Alan Modra  <amodra@gmail.com>
> 	    Pat Haugen  <pthaugen@linux.ibm.com>
> 
> 	PR 94393
> gcc/
> 	* config/rs6000/rs6000.c (rotate_di, is_rotate_positive_constant,
> 	is_rotate_negative_constant, rotate_and_mask_constant): New functions.
> 	(num_insns_constant_multi, rs6000_emit_set_long_const): Use it here.
> 	* config/rs6000/rs6000.md (*movdi_internal64+1 splitter): Delete.
> gcc/testsuite/
> 	* gcc.target/powerpc/rot_cst.h,
> 	* gcc.target/powerpc/rot_cst1.c,
> 	* gcc.target/powerpc/rot_cst2.c: New tests.


      parent reply	other threads:[~2022-01-19 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 19:38 Pat Haugen
2021-12-07 18:47 ` Ping: " Pat Haugen
2021-12-17 20:37 ` Ping^2: " Pat Haugen
2021-12-30 17:06 ` Ping^3: " Pat Haugen
2022-01-13 18:22 ` Ping^4: " Pat Haugen
2022-01-19 21:04 ` Pat Haugen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f6f61f9-3e2f-8bb9-adf7-72ed7fbf7b89@linux.ibm.com \
    --to=pthaugen@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).