* [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A520
@ 2024-03-12 14:08 Richard Ball
2024-03-13 11:34 ` Richard Earnshaw
0 siblings, 1 reply; 2+ messages in thread
From: Richard Ball @ 2024-03-12 14:08 UTC (permalink / raw)
To: gcc-patches, Richard Earnshaw, Richard Sandiford, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
The SCHEDULER_IDENT for this CPU was incorrectly
set to cortexa55, which is incorrect. This can cause
sub-optimal asm to be generated.
Ok for trunk?
gcc/ChangeLog:
PR target/114272
* config/aarch64/aarch64-cores.def (AARCH64_CORE):
Change SCHEDULER_IDENT from cortexa55 to cortexa53
for Cortex-A520.
[-- Attachment #2: Cortex-A520-scheduler.patch --]
[-- Type: text/plain, Size: 875 bytes --]
diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def
index ea84dcb11a2c11fb7d8ada3b66b3caaa39f08daf..f69fc212d56418887e29615f8acdeb02e39750c6 100644
--- a/gcc/config/aarch64/aarch64-cores.def
+++ b/gcc/config/aarch64/aarch64-cores.def
@@ -171,7 +171,7 @@ AARCH64_CORE("cortex-r82", cortexr82, cortexa53, V8R, (), cortexa53, 0x41, 0xd15
/* Arm ('A') cores. */
AARCH64_CORE("cortex-a510", cortexa510, cortexa53, V9A, (SVE2_BITPERM, MEMTAG, I8MM, BF16), cortexa53, 0x41, 0xd46, -1)
-AARCH64_CORE("cortex-a520", cortexa520, cortexa55, V9_2A, (SVE2_BITPERM, MEMTAG), cortexa53, 0x41, 0xd80, -1)
+AARCH64_CORE("cortex-a520", cortexa520, cortexa53, V9_2A, (SVE2_BITPERM, MEMTAG), cortexa53, 0x41, 0xd80, -1)
AARCH64_CORE("cortex-a710", cortexa710, cortexa57, V9A, (SVE2_BITPERM, MEMTAG, I8MM, BF16), neoversen2, 0x41, 0xd47, -1)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A520
2024-03-12 14:08 [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A520 Richard Ball
@ 2024-03-13 11:34 ` Richard Earnshaw
0 siblings, 0 replies; 2+ messages in thread
From: Richard Earnshaw @ 2024-03-13 11:34 UTC (permalink / raw)
To: Richard Ball, gcc-patches, Richard Earnshaw, Richard Sandiford,
Marcus Shawcroft
On 12/03/2024 14:08, Richard Ball wrote:
> The SCHEDULER_IDENT for this CPU was incorrectly
> set to cortexa55, which is incorrect. This can cause
> sub-optimal asm to be generated.
>
> Ok for trunk?
>
> gcc/ChangeLog:
> PR target/114272
> * config/aarch64/aarch64-cores.def (AARCH64_CORE):
> Change SCHEDULER_IDENT from cortexa55 to cortexa53
> for Cortex-A520.
I don't see having this as a separate patch to the one for Cortex-A510
as having any value.
Please merge the two together. A merged patch is pre-approved.
R.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-13 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-12 14:08 [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A520 Richard Ball
2024-03-13 11:34 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).