From: David Holsgrove <david.holsgrove@xilinx.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "Michael Eager (eager@eagerm.com)" <eager@eagerm.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>,
John Williams <jwilliams@xilinx.com>,
Edgar Iglesias <edgari@xilinx.com>
Subject: [Patch, testsuite]: Allow MicroBlaze .weakext pattern in regex match
Date: Fri, 14 Feb 2014 06:07:00 -0000 [thread overview]
Message-ID: <2f748e41-9d19-4217-8bb8-58ee8726f3ae@VA3EHSMHS046.ehs.local> (raw)
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
Hi All,
I've attached a patch to extend the regex pattern to include optional 'ext' at the end of
'.weak' to match the MicroBlaze weak label '.weakext' in two of the g++ testcases.
The only other rule in these tests was for ! { *-*-darwin* }, so I'm not sure if it's appropriate to modify
the scan-assembler line in this fashion for a specific architecture's pattern?
ChangeLog/testsuite
2014-02-14 David Holsgrove <david.holsgrove@xilinx.com>
* gcc/testsuite/g++.dg/abi/rtti3.C: Extend scan-assembler
pattern to take optional ext after .weak.
* gcc/testsuite/g++.dg/abi/thunk4.C: Likewise.
thanks,
David
[-- Attachment #2: 0005-Patch-testsuite-Allow-MicroBlaze-.weakext-pattern-in.patch --]
[-- Type: application/octet-stream, Size: 3026 bytes --]
From 5a20dcc699745b4476a69bcecf2b3ea307af43ae Mon Sep 17 00:00:00 2001
From: David Holsgrove <david.holsgrove@xilinx.com>
Date: Fri, 14 Feb 2014 09:36:45 +1000
Subject: [Patch, testsuite]: Allow MicroBlaze .weakext pattern in regex match
Extend regex pattern to include optional ext at the end of
.weak to match the MicroBlaze weak label .weakext
ChangeLog/testsuite
2014-02-14 David Holsgrove <david.holsgrove@xilinx.com>
* gcc/testsuite/g++.dg/abi/rtti3.C: Extend scan-assembler
pattern to take optional ext after .weak.
* gcc/testsuite/g++.dg/abi/thunk4.C: Likewise.
Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
gcc/testsuite/g++.dg/abi/rtti3.C | 4 ++--
gcc/testsuite/g++.dg/abi/thunk3.C | 2 +-
gcc/testsuite/g++.dg/abi/thunk4.C | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/testsuite/g++.dg/abi/rtti3.C b/gcc/testsuite/g++.dg/abi/rtti3.C
index c03e461..5a39a08 100644
--- a/gcc/testsuite/g++.dg/abi/rtti3.C
+++ b/gcc/testsuite/g++.dg/abi/rtti3.C
@@ -3,8 +3,8 @@
// { dg-require-weak "" }
// { dg-skip-if "Linkonce not weak" { *-*-mingw* *-*-cygwin } { "*" } { "" } }
-// { dg-final { scan-assembler ".weak\[ \t\]_?_ZTSPP1A" { target { ! { *-*-darwin* } } } } }
-// { dg-final { scan-assembler-not ".weak\[ \t\]_?_ZTIPP1A" { target { ! { *-*-darwin* } } } } }
+// { dg-final { scan-assembler ".weak(ext)?\[ \t\]_?_ZTSPP1A" { target { ! { *-*-darwin* } } } } }
+// { dg-final { scan-assembler-not ".weak(ext)?\[ \t\]_?_ZTIPP1A" { target { ! { *-*-darwin* } } } } }
// { dg-final { scan-assembler ".weak_definition\[ \t\]_?_ZTSPP1A" { target { *-*-darwin* } } } }
// { dg-final { scan-assembler-not ".weak_definition\[ \t\]_?_ZTIPP1A" { target { *-*-darwin* } } } }
diff --git a/gcc/testsuite/g++.dg/abi/thunk3.C b/gcc/testsuite/g++.dg/abi/thunk3.C
index f2347f7..dcec8a7 100644
--- a/gcc/testsuite/g++.dg/abi/thunk3.C
+++ b/gcc/testsuite/g++.dg/abi/thunk3.C
@@ -1,5 +1,5 @@
// { dg-require-weak "" }
-// { dg-final { scan-assembler-not ".weak\[\t \]_?_ZThn._N7Derived3FooEv" { target { ! { *-*-darwin* } } } } }
+// { dg-final { scan-assembler-not ".weak(ext)?\[\t \]_?_ZThn._N7Derived3FooEv" { target { ! { *-*-darwin* } } } } }
// { dg-final { scan-assembler-not ".weak_definition\[\t \]_?_ZThn._N7Derived3FooEv" { target { *-*-darwin* } } } }
struct Base
diff --git a/gcc/testsuite/g++.dg/abi/thunk4.C b/gcc/testsuite/g++.dg/abi/thunk4.C
index fa5fbd4..79cb311 100644
--- a/gcc/testsuite/g++.dg/abi/thunk4.C
+++ b/gcc/testsuite/g++.dg/abi/thunk4.C
@@ -1,6 +1,6 @@
// { dg-require-weak "" }
// { dg-skip-if "Linkonce not weak" { *-*-mingw* *-*-cygwin } { "*" } { "" } }
-// { dg-final { scan-assembler ".weak\[ \t\]_?_ZThn._N7Derived3FooEv" { target { ! { *-*-darwin* } } } } }
+// { dg-final { scan-assembler ".weak(ext)?\[ \t\]_?_ZThn._N7Derived3FooEv" { target { ! { *-*-darwin* } } } } }
// { dg-final { scan-assembler ".weak_definition\[ \t\]_?_ZThn._N7Derived3FooEv" { target { *-*-darwin* } } } }
struct Base
--
1.7.9.5
next reply other threads:[~2014-02-14 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 6:07 David Holsgrove [this message]
2014-02-14 8:01 ` Mike Stump
2014-02-17 0:21 ` David Holsgrove
2014-02-20 20:17 ` Mike Stump
2014-02-27 0:29 ` David Holsgrove
2014-02-28 0:55 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f748e41-9d19-4217-8bb8-58ee8726f3ae@VA3EHSMHS046.ehs.local \
--to=david.holsgrove@xilinx.com \
--cc=eager@eagerm.com \
--cc=edgari@xilinx.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwilliams@xilinx.com \
--cc=nmekala@xilinx.com \
--cc=vidhum@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).