From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by sourceware.org (Postfix) with ESMTPS id 5CB60385B503 for ; Sun, 23 Jun 2024 04:04:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CB60385B503 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CB60385B503 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719115466; cv=none; b=rm0CJ9EGvPNwpPhGB8FZYcDZaSC3xzrK+scPDg/xdXwX/7OTeRnkDfX/4ndls1Gkr10Jn61roJ6isIGFvZUXfRuBOBuHhxyXXqD7V7+pNSzDwrfvvllTpmA0buwwnYlTPoRRRemtsNhsCkewTBOJFBssaB/K9p6BZuvO4R760t8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719115466; c=relaxed/simple; bh=bzOULzOaGKVlVNRTXvTRAmLSCKABkR/a79TsbiAFFKY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pZArbd09sbdqLQrR0WFZGlKZY5ixXNuZ8T7NRe2e1OwcOfwWEQg236+q+GndG9lQn/kIZzm7op9F2+qVDSh7fe23UAAupqbYi8RtQTWcZOb1PeTgWkdir1QYKFAmorcS6USQ1oB/ECkB1SbFkTi+rNDV9X7jJXBK12LURhbzm0Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-63186c222eeso30007277b3.2 for ; Sat, 22 Jun 2024 21:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719115463; x=1719720263; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O3lAzpCXBPzn+zcrS7E3sUWbxDm05ufV6nGg+GWpYlQ=; b=CacuI5jbJ5cREJhFfRRVLEz4Q7/mkU75INvc/anuSZyJcvi2MVC9HySwIEQHWS/5B2 20mumMLPF9kdjz8ST8jQ9v5EOjqgLoHD1bWu9qFKgRJ7CMewgjtUqz4INfDpSjaJZ7VO 5E/F4LyN8rHEAb0Tqn/zIl9XHvLBhDwuTsWVAL8n+/wA95fin5dCeddpDMuqJDf4vnRe DyLQ5s20RVOlNaMO1PVBgADH05rbrBj1XC9wgvn9nTXQRr0ZwWsBvNy85uqYJkQ7YGkq Zi7HaqVxus3M6cs4pMbzt8VLbJcZ5+HBxTfET1Se2Yy2Uj4eZ7tDOfiL1/umaVMlNYnA FaIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719115463; x=1719720263; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O3lAzpCXBPzn+zcrS7E3sUWbxDm05ufV6nGg+GWpYlQ=; b=T34t2//862Ixsb61gqfPTEwoaLXje5R11Kybg4O84NaQRluDowieHqo/hcNQ7JYNf5 c9Dmjzo+OguEKFjxmjgCQe4rva/rdNzghccj594wSWbvMZa6puXlk6Q+CEtNjr699yjL WRv3KQCNlRF4wGIPCq9uuUBsC1A3wh0F7eLNt7XAnNr5OkXtVG17fY9dXN2rSFqND5Ny I29pUEpsUnorWm/mmeKa8UdhodN+ajmhjXcXH7H8pIHa2BxQGZ9EUzTiOrrm7M1wFEgs VQcePcwI2Y0TErW9/sZeb5LhgA1a0F2Xb/JkNULNTELNS0zl0OHh8bMd+KFmjylGckpS 61Lg== X-Forwarded-Encrypted: i=1; AJvYcCUSMzT1/iaP1MYYSbAaFOqs0Uya44EXql/7MdXOfm77VO3Vn0Lf7KNgM/xZxEl01PUuq2EE3TDJFewZRrzP6xoV9pJt9BLu4g== X-Gm-Message-State: AOJu0YyeWxOhylOaKJjj6Yvz5guPM8zmId6Iu4OO8rpilZpy8HdDjXsk oa/YrwB8SViJgelUwEAakqEDrBnYHRo677caH813b3Fr0B5WanrO X-Google-Smtp-Source: AGHT+IFtcgxjdB+DcdzhBl3GX+N25tqQwVkd4iKO/jvEvZUpRHN7OcuPbXcSE87YcfZCEkI5Hp2mtw== X-Received: by 2002:a81:ae0d:0:b0:630:8c44:24db with SMTP id 00721157ae682-643aae70b39mr10188997b3.22.1719115463533; Sat, 22 Jun 2024 21:04:23 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id 00721157ae682-63f11173b6csm17362977b3.26.2024.06.22.21.04.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jun 2024 21:04:23 -0700 (PDT) Message-ID: <2f7fe153-fc93-46b4-9dae-c5c0c02347aa@gmail.com> Date: Sat, 22 Jun 2024 22:04:21 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2] RISC-V: Remove integer vector eqne pattern Content-Language: en-US To: "demin.han" , gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, pan2.li@intel.com, rdapp.gcc@gmail.com References: <20240620032820.203996-1-demin.han@starfivetech.com> From: Jeff Law In-Reply-To: <20240620032820.203996-1-demin.han@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/24 9:28 PM, demin.han wrote: > We can unify eqne and other comparison operations. > > Tested on RV32 and RV64. > > gcc/ChangeLog: > > * config/riscv/predicates.md (comparison_except_eqge_operator): Only > exclude ge > (comparison_except_ge_operator): Ditto > * config/riscv/riscv-string.cc (expand_rawmemchr): Use cmp pattern > (expand_strcmp): Ditto > * config/riscv/riscv-vector-builtins-bases.cc: Remove eqne cond > * config/riscv/vector.md (@pred_eqne_scalar): Remove eqne > patterns > (*pred_eqne_scalar_merge_tie_mask): Ditto > (*pred_eqne_scalar): Ditto > (*pred_eqne_scalar_narrow): Ditto > (*pred_eqne_extended_scalar_merge_tie_mask): Ditto > (*pred_eqne_extended_scalar): Ditto > (*pred_eqne_extended_scalar_narrow): Ditto > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/base/integer-cmp-eqne.c: New test. Thanks. I've pushed this to the trunk. jeff