From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 7D78C3851A9A for ; Wed, 31 Aug 2022 08:35:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D78C3851A9A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,277,1654588800"; d="scan'208";a="84981249" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 31 Aug 2022 00:35:05 -0800 IronPort-SDR: QUYGblx5+jdwavwxaTaTURwC5NCWrN3SgAdxnKhz6xp6SilSm7Gm8CvBrUD9gz+UfVAu6Jgcxl 2B8V/Y0nKO0DRoEJDJTQA9hYViwvJitedpgW5Yn+IF12/BWg9thQTHB9Jfjw76uE9p5MyeF9WQ SmmiMGutiKr4KHMW0ngyHh9mc378NeVJEAP7o8huxdiKusjaRKoxVz1yZfpmHmTwpwubmeKeDV YPumVNnJwZrh+7Jh+dVLZh7llI/m7PCAYFVs50qNap7H+tiaCchUrKQ7d+F0THHtmID3/7OGak wt4= Message-ID: <2f98c0dc-8657-4256-76c5-1c87e65d1577@codesourcery.com> Date: Wed, 31 Aug 2022 09:35:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/3] omp-simd-clone: Allow fixed-lane vectors Content-Language: en-GB To: Jakub Jelinek , Rainer Orth CC: References: <290f72ce-e997-0a8c-f11b-cd64edb0859c@codesourcery.com> From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/08/2022 09:29, Jakub Jelinek wrote: > On Tue, Aug 30, 2022 at 06:54:49PM +0200, Rainer Orth wrote: >>> --- a/gcc/omp-simd-clone.cc >>> +++ b/gcc/omp-simd-clone.cc >>> @@ -504,7 +504,10 @@ simd_clone_adjust_return_type (struct cgraph_node *node) >>> veclen = node->simdclone->vecsize_int; >>> else >>> veclen = node->simdclone->vecsize_float; >>> - veclen = exact_div (veclen, GET_MODE_BITSIZE (SCALAR_TYPE_MODE (t))); >>> + if (known_eq (veclen, 0)) >>> + veclen = node->simdclone->simdlen; >>> + else >>> + veclen = exact_div (veclen, GET_MODE_BITSIZE (SCALAR_TYPE_MODE (t))); >>> if (multiple_p (veclen, node->simdclone->simdlen)) >>> veclen = node->simdclone->simdlen; >>> if (POINTER_TYPE_P (t)) >> >> this broke bootstrap on (at least) i386-pc-solaris2.11 and >> sparc-sun-solaris2.11: >> >> In file included from /vol/gcc/src/hg/master/local/gcc/coretypes.h:475, >> from /vol/gcc/src/hg/master/local/gcc/omp-simd-clone.cc:23: >> /vol/gcc/src/hg/master/local/gcc/poly-int.h: In instantiation of 'typename if_nonpoly::type maybe_ne(const poly_int_pod&, const Cb&) [with unsigned int N = 1; Ca = long long unsigned int; Cb = int; typename if_nonpoly::type = bool]': >> /vol/gcc/src/hg/master/local/gcc/omp-simd-clone.cc:507:7: required from here >> /vol/gcc/src/hg/master/local/gcc/poly-int.h:1295:22: error: comparison of integer expressions of different signedness: 'const long long unsigned int' and 'const int' [-Werror=sign-compare] >> 1295 | return a.coeffs[0] != b; >> | ~~~~~~~~~~~~^~~~ >> >> Changing the three instances of 0 to 0U seems to fix this. > > It broke bootstrap for me on x86_64-linux and i686-linux too. > > I've bootstrapped/regtested the following patch on both overnight > and committed to unbreak bootstrap for others. Apologies everyone. :-( I did a full build and test on x86_64, but not a bootstrap, and apparently it was fine with my not-so-new compiler. Andrew