From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D7B843857821 for ; Wed, 14 Jul 2021 22:53:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7B843857821 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-cyNSgQB7Pj-MfF-nAu6i8w-1; Wed, 14 Jul 2021 18:53:50 -0400 X-MC-Unique: cyNSgQB7Pj-MfF-nAu6i8w-1 Received: by mail-qt1-f197.google.com with SMTP id i9-20020ac871c90000b0290252173fe79cso2910820qtp.2 for ; Wed, 14 Jul 2021 15:53:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=OyXUoFlPZYCp3Aft2x2/CrOx1txhVZrobaSW5iRo238=; b=cZxYr6yeq5bOA8fnf9PJZ5nppFNYX3Pcc3BL3wYBIVxZsmLBPsFL81z0VrVP6nGpRg K2iqMHBEFItlxQZGl515KlIRM/FaTFCVoY9hrR+sbjJaEpZZxJg1OrLPBmxGDUY2MKT9 YxnXUo3Se39JgUjbVBL948xEGSNyCqQFpbeIefTGfMlQ0V3GAs206PVMPb9HWh3DE1ov uK+PA+kD7T9IB9wGEjNwOBOUygpZFVjxf6AY8QcUa9XjzCRPsK9yRCSjeNKbR9v8bYrt OQNBXnhOwn0H8GX6jqtcsM7xfi/l1b9ybv1mIbojyLAyrqppzY7KoteoBxDYpjUsCjeL 83SA== X-Gm-Message-State: AOAM531SSudt2282N4J0mHNToCKWkSPouNS7zflbQyj4+aJiLOQeKjEi USdGZTCTirWhNH5tM2a7KYSJ0A5oA2MmXtwQrYIHd20BM1Rnb94MykKyERfeUwOWHCm7YJOtVBZ hzBkzkiTAxSBxEuLTNw== X-Received: by 2002:a05:620a:21d0:: with SMTP id h16mr306826qka.385.1626303229538; Wed, 14 Jul 2021 15:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzubcdhX6AmSfh5DkzjHSet0hLQqK9i+FaIoc1DZq3JTOPf/bnax523XIYqDFldmftB1ysF8g== X-Received: by 2002:a05:620a:21d0:: with SMTP id h16mr306814qka.385.1626303229365; Wed, 14 Jul 2021 15:53:49 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id x21sm1752885qkn.0.2021.07.14.15.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 15:53:48 -0700 (PDT) Message-ID: <2fb46f250bbfaa313dbaec25e5cdc381f9d6e273.camel@redhat.com> Subject: Re: [committed] input.c: move file caching globals to a new file_cache class From: David Malcolm To: Lewis Hyatt Cc: gcc-patches@gcc.gnu.org Date: Wed, 14 Jul 2021 18:53:47 -0400 In-Reply-To: References: <53b40be4f996970ca52ac6fc05419683c2cbfa1d.camel@redhat.com> <20210701215110.1409601-1-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 22:53:53 -0000 On Sun, 2021-07-11 at 12:58 -0400, Lewis Hyatt wrote: > Hi David- > > I thought this might be a good opportunity to ask about the patch > that > supports -finput-charset in diagnostic.c please? > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564527.html > > The patch will require some work to adapt to the new changes below.  Sorry about that, I forgot about your patch. > I > am happy to do that, but thought I should check first whether you > have > any interest in this approach? Thanks! The basic approach seems good to me, so please do update the patch and resend it. Dave