From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1B8493835827 for ; Wed, 23 Jun 2021 04:17:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B8493835827 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15N44DMr014768; Wed, 23 Jun 2021 00:17:17 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39bv8jj0u4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Jun 2021 00:17:17 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15N470LN029144; Wed, 23 Jun 2021 00:17:16 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 39bv8jj0tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Jun 2021 00:17:16 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15N4ELd3000567; Wed, 23 Jun 2021 04:17:14 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3997uh9qyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Jun 2021 04:17:14 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15N4HBnZ32637302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jun 2021 04:17:11 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 347A24204C; Wed, 23 Jun 2021 04:17:11 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D079142049; Wed, 23 Jun 2021 04:17:08 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.74]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 23 Jun 2021 04:17:08 +0000 (GMT) Subject: Re: [EXTERNAL] Re: rs6000: Fix typos in float128 ISA3.1 support To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Bill Schmidt , will schmidt , cel@us.ibm.com, Michael Meissner References: <32c02216-9f50-8b1b-9d5d-43a769c3c149@linux.ibm.com> <20210622185602.GD5077@gate.crashing.org> From: "Kewen.Lin" Message-ID: <2fc5b902-9c0b-89b2-c526-ce6a6f638757@linux.ibm.com> Date: Wed, 23 Jun 2021 12:17:07 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210622185602.GD5077@gate.crashing.org> Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tLdKeVSRzUTCjfK2Kc8-wkTG2hegzP3W X-Proofpoint-GUID: cfB11PVOVBwMWdWMvO6xT_4ZUZd9vPhK X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-06-23_01:2021-06-22, 2021-06-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106230021 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, MIME_CHARSET_FARAWAY, NICE_REPLY_A, RCVD_IN_MSPIKE_BL, RCVD_IN_MSPIKE_L3, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 04:17:20 -0000 Hi Segher, Thanks for the prompt review! on 2021/6/23 ÉÏÎç2:56, Segher Boessenkool wrote: > Hi! > > On Mon, Jun 21, 2021 at 05:27:06PM +0800, Kewen.Lin wrote: >> Recently if we build gcc on Power with the assembler which doesn't >> have Power10 support, the build will fail when building libgcc with >> one error message like: >> >> Error: invalid switch -mpower10 >> Error: unrecognized option -mpower10 >> make[2]: *** [...gcc/gcc-base/libgcc/shared-object.mk:14: float128-p10.o] Error 1 > > In general, it is recommended to use a binutils of approximately the > same age as the GCC you are trying to build. This is similar to us not > supporting most other non-sensical configurations. An important reason > for that is it cannot ever be tested, there are just too many strange > combinations possible. > > That said :-) > Ah, ok! It explained why no one reported this. I only used the customized binutils for Power10 build/testing before, will work with one new binutils from now on. It did have more testing coverage. >> By checking the culprit commit r12-1340, it's caused by some typos. > > (That is 9090f4807161.) > >> - fix test case used for libgcc_cv_powerpc_3_1_float128_hw check. > > I was confused here for a bit, "test case" usually means something in > testsuite/, I'd call this just "test" :-) > >> BTW, there are some noises during regression testings due to >> newer versions binutils, but they were identified as unrelated >> after some checkings. > > Hrm, what kind of noise? > Some check selectors will fail without new binutils, those cases becomes unsupported, like Power10 support checks. The location of our pre-built binutils in our system has not only binutils but also some other tools like newer version gdb, which caused some differences such as for guality cases. >> * config/rs6000/t-float128-hw(fp128_3_1_hw_funcs, >> fp128_3_1_hw_src, fp128_3_1_hw_static_obj, fp128_3_1_hw_shared_obj, >> fp128_3_1_hw_obj): Remove variables for ISA 3.1 support. > > Needs a space before the opening paren. Doesn't need a line break so > early on that line btw. > Good catch, fixed. > Just "Remove." or "Delete." is less confusing btw: what you wrote can be > read as "Remove the variables from these declarations" or similar. And > of course terseness is usually best in a changelog. > Fixed. >> * config/rs6000/t-float128-p10-hw (FLOAT128_HW_INSNS): Append >> macro FLOAT128_HW_INSNS_ISA3_1 for ISA 3.1 support. > > Don't say what it is for, just say what changed :-) > Fixed. >> (FP128_3_1_CFLAGS_HW): Fix option typo. >> * config/rs6000/float128-ifunc.c (SW_OR_HW_ISA3_1): Guarded >> with FLOAT128_HW_INSNS_ISA3_1. > > "Guard", not "Guarded", all entries are written in the imperative, like, > "Do this" or "Guard that". > Got it, fixed. >> +#ifdef FLOAT128_HW_INSNS_ISA3_1 >> TFtype __floattikf (TItype_ppc) >> __attribute__ ((__ifunc__ ("__floattikf_resolve"))); > > I wonder if we now need TItype_ppc at all anymore, btw? > Sorry that I don't quite follow this question. I think it stands for type signed int128, the function is to convert signed int128 to float128, it would be needed here. But I think that's not what you asked. Or you are referring to replace this type with signed int128 without shielding it with mode? If yes, it sounds like a question for Mike. > Okay for trunk with the changelog slightly massaged. Thanks! > Thanks for catching changelog problems and the fix suggestion! Fixed all of them accordingly and committed in r12-1738. BR, Kewen