From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 77AEE3853805 for ; Tue, 22 Jun 2021 20:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77AEE3853805 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-DX2APaMCNJirWZdWPQ00oQ-1; Tue, 22 Jun 2021 16:21:47 -0400 X-MC-Unique: DX2APaMCNJirWZdWPQ00oQ-1 Received: by mail-qk1-f199.google.com with SMTP id o189-20020a378cc60000b02903b2ccd94ea1so2936045qkd.19 for ; Tue, 22 Jun 2021 13:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q6M6e7NzKbGRfVpcz2PXsWLANxtsAnEtExmT9W526HY=; b=hiB0IlmXXkXV+mykv1TOBe25oDQZqTbdJBZpfk17jlkqjZ7JoRxqNAQD32KjWHaaz3 9uRQEtXoEPO+101cR4sNHh1/t5qUqBMgvP267bbEpb8AI+4fOinUNHtzIst3xIENCJRj z7QlceIwqwidRI7gByLy8IgRu7jN/NNH9sWqerdRXfu8zVsYW075xu8XKX8WyiQspE5L M8d6IZHHaAs+Y6gPo+Q0r5btaQdbLVaEzhhEYRUIVukKv2cR8mDi7VQ0yQJGjOB47x97 3BvHidmX2qz3ACRo9WWHzIBTCQT4DcWU8152dzDWspCeP1XH+iqM+Edd981bzyHUNEMu mBFA== X-Gm-Message-State: AOAM5314uk+o1lhGhpNSezgMhiAUXry/Up7GOJvO7E5Pmq8m+0OE/YHc yd6lveufiBAfJuVMPFvMX2frROWSfGhAobouvm0jD7VzhX0fojDe/EWtEpxCIwoanZ/IKUh18Oa +18zTUiVbWtUN0YtafmmbAnSpo+lU7DYezAj5igFxgnAyU2avssrCDWvS5pHRxs+eEA== X-Received: by 2002:ad4:4852:: with SMTP id t18mr626681qvy.33.1624393306781; Tue, 22 Jun 2021 13:21:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzh70KLgC1hN91acKDeItopZe6/jcT2B1BT1Wya7M7pyONnjzGZNomDSE48h9OWoHC5GxTC0Q== X-Received: by 2002:ad4:4852:: with SMTP id t18mr626662qvy.33.1624393306557; Tue, 22 Jun 2021 13:21:46 -0700 (PDT) Received: from [192.168.1.148] (130-44-159-43.s11817.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id f204sm2302860qke.84.2021.06.22.13.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 13:21:45 -0700 (PDT) Subject: Re: [[PATCH V9] 3/7] CTF/BTF debug formats To: "Jose E. Marchesi" , gcc-patches@gcc.gnu.org References: <20210531165802.5686-1-jose.marchesi@oracle.com> <20210531165802.5686-4-jose.marchesi@oracle.com> From: Jason Merrill Message-ID: <300e7d1a-593b-af38-4430-336843c62f42@redhat.com> Date: Tue, 22 Jun 2021 16:21:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210531165802.5686-4-jose.marchesi@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 20:21:51 -0000 On 5/31/21 12:57 PM, Jose E. Marchesi via Gcc-patches wrote: > @@ -28219,7 +28219,7 @@ dwarf2out_source_line (unsigned int line, unsigned int column, > dw_line_info_table *table; > static var_loc_view lvugid; > > - if (debug_info_level < DINFO_LEVEL_TERSE) > + if (debug_info_level < DINFO_LEVEL_TERSE || !dwarf_debuginfo_p ()) This should have a comment that the current dwarf-based debug formats don't use line info. Jason