Re: [PATCH] RISC-V: Tweak the wording for the sorry message

[rep.dot.nop@gmail.com]

On 19 January 2024 03:41:57 CET, Kito Cheng <kito.cheng@gmail.com> wrote:
>Thanks, pushed to trunk :)

Thanks, but don't you have to update the tests too, at least
gcc/testsuite/gcc.target/riscv/rvv/base/big_endian-2.c ?

thanks

>
>On Fri, Jan 19, 2024 at 10:36 AM juzhe.zhong@rivai.ai
><juzhe.zhong@rivai.ai> wrote:
>>
>> OK
>>
>> ________________________________
>> juzhe.zhong@rivai.ai
>>
>>
>> From: Kito Cheng
>> Date: 2024-01-19 10:34
>> To: rep.dot.nop; jeffreyalaw; rdapp.gcc; juzhe.zhong; gcc-patches
>> CC: Kito Cheng
>> Subject: [PATCH] RISC-V: Tweak the wording for the sorry message
>> Use "does not" rather than "cannot", because it's implementation issue.
>>
>> gcc/ChangeLog:
>>
>> * config/riscv/riscv.cc (riscv_override_options_internal): Tweak
>> sorry message.
>> ---
>> gcc/config/riscv/riscv.cc | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
>> index f1d5129397f..dd6e68a08c2 100644
>> --- a/gcc/config/riscv/riscv.cc
>> +++ b/gcc/config/riscv/riscv.cc
>> @@ -8798,13 +8798,13 @@ riscv_override_options_internal (struct gcc_options *opts)
>>       We can only allow TARGET_MIN_VLEN * 8 (LMUL) < 65535.  */
>>    if (TARGET_MIN_VLEN_OPTS (opts) > 4096)
>> -    sorry ("Current RISC-V GCC cannot support VLEN greater than 4096bit for "
>> +    sorry ("Current RISC-V GCC does not support VLEN greater than 4096bit for "
>>    "'V' Extension");
>>    /* FIXME: We don't support RVV in big-endian for now, we may enable RVV with
>>       big-endian after finishing full coverage testing.  */
>>    if (TARGET_VECTOR && TARGET_BIG_ENDIAN)
>> -    sorry ("Current RISC-V GCC cannot support RVV in big-endian mode");
>> +    sorry ("Current RISC-V GCC does not support RVV in big-endian mode");
>>    /* Convert -march to a chunks count.  */
>>    riscv_vector_chunks = riscv_convert_vector_bits (opts);
>> --
>> 2.34.1
>>
>>