From: "David Edelsohn" <dje.gcc@gmail.com>
To: "Andreas Tobler" <andreast-list@fgznet.ch>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>,
"Java Patches" <java-patches@gcc.gnu.org>
Subject: Re: [patch] libffi, fix powerpc-unknown-freebsd
Date: Sun, 24 Aug 2008 23:11:00 -0000 [thread overview]
Message-ID: <303e1d290808241503k22ecababm5ed70bb37b1f69c5@mail.gmail.com> (raw)
In-Reply-To: <48B1BFB1.6010407@fgznet.ch>
On Sun, Aug 24, 2008 at 4:08 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:
> I have an understanding issue here, what bits are you referring to? The
> FLAG_SYSV_SMST_R4 and FLAG_SYSV_SMST_R3 from ffi.c?
> Or the situation that I use FFI_SYSV_TYPE_SMALL_STRUCT and the two flags?
> If the former, then my impression is that they don't need to be mentioned in
> ffitarget.h, otherwise we'd have to describe every flag used in ffi.c in
> ffitarget.h as well.
> If the latter, I can put a note into ffitarget.h mentioning that we need
> additional separation in ffi.c to clearly distinguish what we return.
FLAG_SYSV_TYPE_SMALL_STRUCT uses two bits in flags, if I understand
the code correctly. I think it would be helpful to note that in
ffitarget.h
Thanks, David
next prev parent reply other threads:[~2008-08-24 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 15:18 David Edelsohn
2008-08-21 22:50 ` Andreas Tobler
2008-08-22 5:24 ` David Edelsohn
2008-08-24 22:04 ` Andreas Tobler
2008-08-24 23:11 ` David Edelsohn [this message]
2008-08-25 19:45 ` Andreas Tobler
2008-09-10 20:14 ` Andreas Tobler
-- strict thread matches above, loose matches on Subject: below --
2008-08-18 20:48 Andreas Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=303e1d290808241503k22ecababm5ed70bb37b1f69c5@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=andreast-list@fgznet.ch \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).