public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "David Edelsohn" <dje.gcc@gmail.com>
To: "Andrey Belevantsev" <abel@ispras.ru>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>,
	"Jim Wilson" <wilson@tuliptree.org>,
	 	"Vladimir Makarov" <vmakarov@redhat.com>,
	 	"Ayal Zaks" <ZAKS@il.ibm.com>,
	 	"Mark Mitchell" <mark@codesourcery.com>
Subject: Re: Selective scheduling pass - target changes (ia64 & rs6000) [3/3]
Date: Fri, 29 Aug 2008 15:10:00 -0000	[thread overview]
Message-ID: <303e1d290808280820p6497e7bdy614393a4c0bd5377@mail.gmail.com> (raw)

	* config/rs6000/rs6000.c (rs6000_init_sched_context,
	rs6000_alloc_sched_context, rs6000_set_sched_context,
	rs6000_free_sched_context): New functions.
	(struct _rs6000_sched_context): New.
	(rs6000_sched_reorder2): Do not modify INSN_PRIORITY for selective
	scheduling.
	(rs6000_sched_finish): Do not run for selective scheduling.

The rs6000 part of the patch is okay with a modification to the following chunk:

*************** rs6000_sched_finish (FILE *dump, int sch
*** 20085,20091 ****

    if (reload_completed && rs6000_sched_groups)
      {
!       if (rs6000_sched_insert_nops == sched_finish_none)
        return;

        if (rs6000_sched_insert_nops == sched_finish_pad_groups)
--- 20103,20110 ----

    if (reload_completed && rs6000_sched_groups)
      {
!       if (rs6000_sched_insert_nops == sched_finish_none
!         || sel_sched_p ())
        return;

        if (rs6000_sched_insert_nops == sched_finish_pad_groups)


Please change this to a separate test for clarify

+       /* Do not run sched_finish hook when selective scheduling enabled.  */
+       if (sel_sched_p ())
+        return;
+
        if (rs6000_sched_insert_nops == sched_finish_none)
          return;

instead of combining the tests.


Also, target maintainers have flexibility during stage 3 with respect
to changes local to a port,
so the Itanium changes can be approved and committed during stage 3,
although earlier would
be better.

Thanks, David

             reply	other threads:[~2008-08-28 15:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 15:10 David Edelsohn [this message]
2008-08-31 13:35 ` Andrey Belevantsev
  -- strict thread matches above, loose matches on Subject: below --
2008-06-03 14:24 [RFC] Selective scheduling pass Andrey Belevantsev
2008-06-03 14:28 ` Selective scheduling pass - target changes (ia64 & rs6000) [3/3] Andrey Belevantsev
2008-08-22 16:04   ` Andrey Belevantsev
2008-09-25 22:39     ` sje
2008-09-26 14:57       ` Andrey Belevantsev
2008-10-03 22:22         ` Steve Ellcey
2008-10-06 17:26           ` Andrey Belevantsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=303e1d290808280820p6497e7bdy614393a4c0bd5377@mail.gmail.com \
    --to=dje.gcc@gmail.com \
    --cc=ZAKS@il.ibm.com \
    --cc=abel@ispras.ru \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=vmakarov@redhat.com \
    --cc=wilson@tuliptree.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).