From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 1A3A23858D38 for ; Mon, 10 Apr 2023 20:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A3A23858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id la3so5535150plb.11 for ; Mon, 10 Apr 2023 13:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681159166; x=1683751166; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ReKi2DP+cczj5y02PBTrCEAHlNOQS7+Mfxu11WoaXn8=; b=OUmAefW0pKgzwxACAd93u4NED/4g0j283JRwM4fY/UfOO+yhJjN5erL3VEswRZ7UID eMBq5D4GPcdYcFDBZbzDD2IdFA3Qi6gsV6/SjZOkicmozy7BS+6TqoeJW1fa30UmENiR egfxGghna4qTNewSWBc2zUEf4IiiAiODDW7HxHTrhiOR78ntc/LnOmJuF4h9m8CMHKlc 25XbZPitLapFAvxIfYBhITi7IQ9kqmYsauLG82O5VA1xNN98ShvFq8TF1tU/VABSfeuh m5b3+vE92ascV8lcA/w8ZT4RQY4ERXfNcuSUvxecckNS0dyDhbDc+AgNEdpJQJgUgbEl lkDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681159166; x=1683751166; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ReKi2DP+cczj5y02PBTrCEAHlNOQS7+Mfxu11WoaXn8=; b=lUJEkHGeGejJzVV5VawkIgVMLWV3mk1I8MiKTZehNJ7DkJHatalbeYUUezjDS5jN2p GJQr0sdAm0usyLkgSOZPiIZsVZybAQJ1VNPQ3tVTJXs/5bddwjbga6IB1QncIbVmE98R 72bJen4SHbEcDw6zuJ0rDG/OEHvX7S2WChZxEsjGCWmvc/9FE2hTQXNPuNTfmQIWF0fd /CdEqOOc6M+gHxd8nR+tQrNfCrB/nkJcZz4C2Hws1Y7ZT/yxAXzaVif0ZInAbHfJUNfl 9NyMxSl9W+R7fLA5ZfXPxBp5XU2RpxJpeSMP0xKd9FoUYPHsMwy7lKCzV6VI78xdvXMx oTCQ== X-Gm-Message-State: AAQBX9eO05qczz8WXnWTgar7uxRm5bKqPV6OkIvy4tcgwkEStt7DeH29 AJGAA6eDLbhQf3HKjOZdFvOGoLELNZo= X-Google-Smtp-Source: AKy350bCL8XJ0l7iEFVU2/A94mOLTfCVjyZLggHOewzoq6VTnqa1guoxwkh1qYe4ZuvUKKCC0Itj5g== X-Received: by 2002:a17:902:cec3:b0:19a:aa0e:2d67 with SMTP id d3-20020a170902cec300b0019aaa0e2d67mr14203185plg.32.1681159165748; Mon, 10 Apr 2023 13:39:25 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id n1-20020a1709026a8100b0019c91d3bdb4sm6600608plk.304.2023.04.10.13.39.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 13:39:25 -0700 (PDT) Message-ID: <303ff180-6b1d-a655-2678-4e857ce7d15e@gmail.com> Date: Mon, 10 Apr 2023 14:39:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] machine_mode type size: Extend enum size from 8-bit to 16-bit Content-Language: en-US To: juzhe.zhong@rivai.ai, jakub Cc: gcc-patches , "kito.cheng" , palmer , "richard.sandiford" , rguenther References: <20230410144808.324346-1-juzhe.zhong@rivai.ai> <89f088ec-8692-01f5-0395-5a66ddf085d7@gmail.com> <20230410232205400970205@rivai.ai> <6B0515CD206AB305+20230410233334379633207@rivai.ai> From: Jeff Law In-Reply-To: <6B0515CD206AB305+20230410233334379633207@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/10/23 09:33, juzhe.zhong@rivai.ai wrote: > I saw many redundant scalar modes: > >  E_CDImode,               /* machmode.def:267 */ > #define HAVE_CDImode > #ifdef USE_ENUM_MODES > #define CDImode E_CDImode > #else > #define CDImode (complex_mode ((complex_mode::from_int) E_CDImode)) > #endif >   E_CTImode,               /* machmode.def:267 */ > #define HAVE_CTImode > #ifdef USE_ENUM_MODES > #define CTImode E_CTImode > #else > #define CTImode (complex_mode ((complex_mode::from_int) E_CTImode)) > #endif >   E_HCmode,                /* machmode.def:269 */ > #define HAVE_HCmode > #ifdef USE_ENUM_MODES > #define HCmode E_HCmode > #else > #define HCmode (complex_mode ((complex_mode::from_int) E_HCmode)) > #endif >   E_SCmode,                /* machmode.def:269 */ > #define HAVE_SCmode > #ifdef USE_ENUM_MODES > #define SCmode E_SCmode > #else > #define SCmode (complex_mode ((complex_mode::from_int) E_SCmode)) > #endif >   E_DCmode,                /* machmode.def:269 */ > #define HAVE_DCmode > #ifdef USE_ENUM_MODES > #define DCmode E_DCmode > #else > #define DCmode (complex_mode ((complex_mode::from_int) E_DCmode)) > #endif >   E_TCmode,                /* machmode.def:269 */ > #define HAVE_TCmode > #ifdef USE_ENUM_MODES > #define TCmode E_TCmode > #else > #define TCmode (complex_mode ((complex_mode::from_int) E_TCmode)) > #endif > ... > > These scalar modes are redundant I think, can we forbid them? > There are 40+ scalar modes that are not used. Those are fairly standard complex modes. Those are unlikely to go away. Some of those might be redundant with 2 element vector modes, but I'd hesitate to do something like using CDI to represent a 2XDI vector.