public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bill Schmidt <wschmidt@linux.ibm.com>
To: Michael Meissner <meissner@linux.ibm.com>,
	gcc-patches@gcc.gnu.org,
	Segher Boessenkool <segher@kernel.crashing.org>,
	David Edelsohn <dje.gcc@gmail.com>,
	Peter Bergner <bergner@linux.ibm.com>,
	Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] Fix regular expression error in PR 100166 patch
Date: Wed, 14 Jul 2021 16:51:52 -0500	[thread overview]
Message-ID: <3055f80e-42fe-e1af-b8e3-77c05dbcfa2b@linux.ibm.com> (raw)
In-Reply-To: <20210714214217.GA12025@ibm-toto.the-meissners.org>

Hi Mike,

On 7/14/21 4:42 PM, Michael Meissner wrote:
> Fix regular expression error in PR 100166 patch
>
> In my patch for PR testsuite/100166 (which fixes various tests so that the
> plxv and pstxv instructions can be counted as legitimate instructions), I
> had a typo in the pr86731-fwrapv-longlong.c test (using plvx instead of
> plxv).  This patch fixes this error.
>
> Can I apply it to the mainline?  I have tested this on a big endian power8
> system (using --with-cpu=power8), a little endian power9 system (using
> --with-cpu=power9), and on a power10 prototype (using --with-cpu=power10).  The
> pr86731-fwrapv-longlong.c test passes in all cases.
>
> 2021-07-14  Michael Meissner  <meissner@linux.ibm.com>
>
> gcc/testsuite/
> 	PR testsuite/100166
> 	* gcc.target/powerpc/pr86731-fwrapv-longlong.c: Fix typo.
> ---
>   gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
> index bd1502bb30a..97bc60f7cd6 100644
> --- a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c
> @@ -30,5 +30,5 @@ vector signed long long splats4(void)
>   
>   /* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 0 } } */
>   /* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 0 } } */
> -/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlxv\M|\mlxvd2x\M} 2 } } */
> +/* { dg-final { scan-assembler-times {\mp?lxv?\M|\mlxvd2x\M} 2 } } */
>   

That doesn't look like what you meant to do... That would accept "lx" 
among other strings...

Thanks,
Bill


  reply	other threads:[~2021-07-14 21:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 21:42 Michael Meissner
2021-07-14 21:51 ` Bill Schmidt [this message]
2021-07-14 22:27   ` Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3055f80e-42fe-e1af-b8e3-77c05dbcfa2b@linux.ibm.com \
    --to=wschmidt@linux.ibm.com \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=meissner@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).